You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/01/25 00:56:13 UTC
Review Request 65329: [ATLAS-2420]: Create indexes for relationship
attributes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65329/
-----------------------------------------------------------
Review request for atlas and Madhan Neethiraj.
Bugs: ATLAS-2420
https://issues.apache.org/jira/browse/ATLAS-2420
Repository: atlas
Description
-------
Currently attributes and system attributes (guid) of relationship is not indexed. This Jira enables adding indexing for relationship attributes. It makes use of edge_index in solr.
Diffs
-----
common/src/main/java/org/apache/atlas/repository/Constants.java d63f361b
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 620ba101
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java 036c566f
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java 43b95cae
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java ed4099b8
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphManagement.java 5b9c9330
graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/AbstractGraphDatabaseTest.java fbbfdef4
graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java 3756382f
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 9f1206ca
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 4da74b94
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java 9301cfaa
Diff: https://reviews.apache.org/r/65329/diff/1/
Testing
-------
Verified in indexing backend (solr), indexes were created for relationship attributes.
Thanks,
Sarath Subramanian
Re: Review Request 65329: [ATLAS-2420]: Create indexes for
relationship attributes
Posted by Sarath Subramanian <sa...@apache.org>.
> On Jan. 27, 2018, 10:43 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
> > Lines 347 (patched)
> > <https://reviews.apache.org/r/65329/diff/2/?file=1946844#file1946844line401>
> >
> > line #347 should be removed - as this shouldn't be executed for relationship-type and it is already executed in line #344 for other types.
good catch! missed to remove it.
- Sarath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65329/#review196388
-----------------------------------------------------------
On Jan. 24, 2018, 4:56 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65329/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2018, 4:56 p.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2420
> https://issues.apache.org/jira/browse/ATLAS-2420
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently attributes and system attributes (guid) of relationship is not indexed. This Jira enables adding indexing for relationship attributes. It makes use of edge_index in solr.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java d63f361b
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 620ba101
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java 036c566f
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java 43b95cae
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java ed4099b8
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphManagement.java 5b9c9330
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/AbstractGraphDatabaseTest.java fbbfdef4
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java 3756382f
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 9f1206ca
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 8c886100
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java cf414bf4
>
>
> Diff: https://reviews.apache.org/r/65329/diff/2/
>
>
> Testing
> -------
>
> Verified in indexing backend (solr), indexes were created for relationship attributes.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 65329: [ATLAS-2420]: Create indexes for
relationship attributes
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65329/#review196388
-----------------------------------------------------------
Fix it, then Ship it!
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
Lines 347 (patched)
<https://reviews.apache.org/r/65329/#comment276016>
line #347 should be removed - as this shouldn't be executed for relationship-type and it is already executed in line #344 for other types.
- Madhan Neethiraj
On Jan. 25, 2018, 12:56 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65329/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2018, 12:56 a.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2420
> https://issues.apache.org/jira/browse/ATLAS-2420
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently attributes and system attributes (guid) of relationship is not indexed. This Jira enables adding indexing for relationship attributes. It makes use of edge_index in solr.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java d63f361b
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 620ba101
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java 036c566f
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java 43b95cae
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java ed4099b8
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphManagement.java 5b9c9330
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/AbstractGraphDatabaseTest.java fbbfdef4
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java 3756382f
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 9f1206ca
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 8c886100
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java cf414bf4
>
>
> Diff: https://reviews.apache.org/r/65329/diff/2/
>
>
> Testing
> -------
>
> Verified in indexing backend (solr), indexes were created for relationship attributes.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 65329: [ATLAS-2420]: Create indexes for
relationship attributes
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65329/#review196396
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Jan. 25, 2018, 12:56 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65329/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2018, 12:56 a.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2420
> https://issues.apache.org/jira/browse/ATLAS-2420
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently attributes and system attributes (guid) of relationship is not indexed. This Jira enables adding indexing for relationship attributes. It makes use of edge_index in solr.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java d63f361b
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 620ba101
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java 036c566f
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java 43b95cae
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java ed4099b8
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphManagement.java 5b9c9330
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/AbstractGraphDatabaseTest.java fbbfdef4
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java 3756382f
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 9f1206ca
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 8c886100
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java cf414bf4
>
>
> Diff: https://reviews.apache.org/r/65329/diff/3/
>
>
> Testing
> -------
>
> Verified in indexing backend (solr), indexes were created for relationship attributes.
>
>
> Thanks,
>
> Sarath Subramanian
>
>