[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #7572: [SQL Lab] Show warning when user used up localStorage

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #7572: [SQL Lab] Show warning when user used up localStorage
URL: https://github.com/apache/incubator-superset/pull/7572#discussion_r291455471
 
 

 ##########
 File path: superset/assets/src/SqlLab/constants.js
 ##########
 @@ -48,3 +48,13 @@ export const TIME_OPTIONS = [
 export const SQL_EDITOR_GUTTER_HEIGHT = 5;
 export const SQL_EDITOR_GUTTER_MARGIN = 3;
 export const SQL_TOOLBAR_HEIGHT = 51;
+
+// kilobyte storage
+export const KB_STORAGE = 1024;
+export const BYTES_PER_CHAR = 2;
+
+// browser's localStorage max usage constants
+export const LOCALSTORAGE_MAX_QUERY_AGE_MS = 24 * 60 * 60 * 1000; // 24 hours
+export const LOCALSTORAGE_MAX_USAGE_KB = 5 * 1024; // 5M
 
 Review comment:
   As a project I think we should target "modern browsers", whatever that means today and tomorrow. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org