You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/02 06:17:04 UTC

[GitHub] [pulsar] Jason918 opened a new pull request #13082: [broker] Optimize TopicPolicy#maxProducersPerTopic with HierarchyTopicPolicies

Jason918 opened a new pull request #13082:
URL: https://github.com/apache/pulsar/pull/13082


   ### Motivation
   
   This is one of the serial topic policy optimization with `HierarchyTopicPolicies`. 
   
   Update topic policy with HierarchyTopicPolicies comes with these benefits:
   - All topic policy related settings will goes into AbstractTopic#topicPolicies, easier to understand, check, review, and modify.
   - Unify policy update to AbstractTopic. And easier to find which policy is not applied to non-persistent topic yet. And we can easily add support for it.
   - Unify policy value with 3 level settings (topic/namespace/broker), and priority with topic > namespace > broker.  And it's easier to find which level settings is missing.
   - All values are updated at creation or by trigger. We can save some resource to update it or recalculate each time we use it. 
   - etc.
   
   ### Modifications
   
   Add new field `maxProducersPerTopic` in org.apache.pulsar.broker.service.AbstractTopic#topicPolicies.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   This change is already covered by existing tests, such as org.apache.pulsar.broker.service.persistent.testSetMaxProducers
   
   Some checklist for updating topic policy with `HierarchyTopicPolicies`.
   
   - [x] Broker level value set. And this configuration is not dynamic. (Not supported yet)
   - [x] Namespace level value updated.
   - [x] Topic level value updated.
   - [x] Pre-existing unit test covers this change and updated to verify this change.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
     
   - [x] `no-need-doc` 
   
   Code optimization.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #13082: [broker] Optimize TopicPolicy#maxProducersPerTopic with HierarchyTopicPolicies

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #13082:
URL: https://github.com/apache/pulsar/pull/13082


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jason918 commented on pull request #13082: [broker] Optimize TopicPolicy#maxProducersPerTopic with HierarchyTopicPolicies

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #13082:
URL: https://github.com/apache/pulsar/pull/13082#issuecomment-985091573


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jason918 commented on pull request #13082: [broker] Optimize TopicPolicy#maxProducersPerTopic with HierarchyTopicPolicies

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #13082:
URL: https://github.com/apache/pulsar/pull/13082#issuecomment-985178112


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org