You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/20 02:36:37 UTC
[GitHub] [incubator-seatunnel] liugddx opened a new pull request, #2800: [Improve][DOC] Perfect the connector v2 doc
liugddx opened a new pull request, #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
Perfect the connector v2 doc
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#issuecomment-1256992535
> done
Please change the content of the above screenshot, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#issuecomment-1257439870
Done. @EricJoy2048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#issuecomment-1252211452
How about change English doc too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#issuecomment-1256965994
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#discussion_r979538093
##########
seatunnel-connectors-v2/README.zh.md:
##########
@@ -1,64 +1,127 @@
## 目的
-Because SeaTunnel design new API for connectors, 所以通过这篇文章来介绍新的接口以及新的代码结构，方便开发者快速的帮助新API和翻译层完善，以及开发出新的Connecotor.
+
+SeaTunnel为与计算引擎进行解耦，设计了新的连接器API，通过这篇文章来介绍新的接口以及新的代码结构，方便开发者快速上手使用新版API开发连接器并理解新版API运行原理.
+详细设计请查看该[提议](https://github.com/apache/incubator-seatunnel/issues/1608) 。
+
## 代码结构
-现阶段所有相关代码保存在`api-draft`分支上。
+
为了和老的代码分开，方便现阶段的并行开发，以及降低merge的难度。我们为新的执行流程定义了新的模块
+
### Example
-我们已经在`seatunnel-examples`中准备好了新版本的可本地执行Example程序，直接调用`seatunnel-flink-connector-v2-example`或`seatunnel-spark-connector-v2-example`中的`SeaTunnelApiExample`即可。这也是本地开发Connector经常会用到的调试方式。
-对应的配置文件保存在同模块的`resources/examples`文件夹下，和以前一样。
+
+我们已经在`seatunnel-examples`
+准备了两个本地可执行的案例程序,其中一个是`seatunnel-examples/seatunnel-flink-connector-v2-example/src/main/java/org/apache/seatunnel/example/flink/v2/SeaTunnelApiExample.java`
+，它运行在flink引擎上。另外一个是`seatunnel-examples/seatunnel-spark-connector-v2-example/src/main/java/org/apache/seatunnel/example/spark/v2/SeaTunnelApiExample.java`
+，它运行在spark引擎上。你可以通过调试这些例子帮你更好的理解程序运行逻辑。使用的配置文件保存在`resources/examples`文件夹里。如果你想增加自己的connectors，你需要按照下面的步骤。
+
+1. 在`seatunnel-examples/seatunnel-flink-connector-v2-example/pom.xml`添加connector依赖的groupId, artifactId 和
+ version.（或者当你想在spark引擎运行时在`seatunnel-examples/seatunnel-spark-connector-v2-example/pom.xml`添加依赖）
+2. 如果你的connector存在scope为test或者provided的依赖则在`seatunnel-examples/seatunnel-flink-connector-v2-example/pom.xml`(
Review Comment:
> 如果你的connector存在scope为test或者provided的依赖则在`seatunnel-examples/seatunnel-flink-connector-v2-example/pom.xml`(
或者在`seatunnel-examples/seatunnel-spark-connector-v2-example/pom.xml`)修改为compile。
如果你的connector中存在scope为test或provided的依赖，将这些依赖添加到`seatunnel-examples/seatunnel-flink-connector-v2-example/pom.xml`(
或者在`seatunnel-examples/seatunnel-spark-connector-v2-example/pom.xml`)中，并且修改scope为compile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#issuecomment-1256913171
> > @TyrantLucifer @EricJoy2048
>
> PTAL
Now the document still has some incoherent and unreasonable places, please modify according to the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#discussion_r979212603
##########
seatunnel-connectors-v2/README.md:
##########
@@ -1,48 +1,101 @@
# Purpose
-This article introduces the new interface and the new code structure on account of the newly designed API for Connectors in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and development of new Connector.
+
+This article introduces the new interface and the new code structure on account of the newly designed API for Connectors
+in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and
+development of new Connector.
## **Code Structure**
-In order to separate from the old code, we have defined new modules for execution flow. This facilitates parallel development at the current stage, and reduces the difficulty of merging. All the relevant code at this stage is kept on the ``api-draft`` branch.
+
+In order to separate from the old code, we have defined new modules for execution flow. This facilitates parallel
+development at the current stage, and reduces the difficulty of merging.
### **Example**
-We have prepared a new version of the locally executable example program in ``seatunnel-examples``, which can be directly called using ``seatunnel-flink-connector-v2-example`` or ``seatunnel-spark-connector-v2-example`` in ``SeaTunnelApiExample``. This is also the debugging method that is often used in the local development of Connector. The corresponding configuration files are saved in the same module ``resources/examples`` folder as before.
+We have prepared a new version of the locally executable example program in ``seatunnel-examples``, which can be
+directly called using ``seatunnel-flink-connector-v2-example`` or ``seatunnel-spark-connector-v2-example``
+in ``SeaTunnelApiExample``. This is also the debugging method that is often used in the local development of Connector.
Review Comment:
> This is also the debugging method that is often used in the local development of Connector.
This is also the debugging method that is often used in the local development of Connector. You can debug these examples, which will help you better understand the running logic of the program.
##########
seatunnel-connectors-v2/README.md:
##########
@@ -1,48 +1,101 @@
# Purpose
-This article introduces the new interface and the new code structure on account of the newly designed API for Connectors in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and development of new Connector.
+
+This article introduces the new interface and the new code structure on account of the newly designed API for Connectors
+in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and
+development of new Connector.
## **Code Structure**
-In order to separate from the old code, we have defined new modules for execution flow. This facilitates parallel development at the current stage, and reduces the difficulty of merging. All the relevant code at this stage is kept on the ``api-draft`` branch.
+
+In order to separate from the old code, we have defined new modules for execution flow. This facilitates parallel
+development at the current stage, and reduces the difficulty of merging.
### **Example**
-We have prepared a new version of the locally executable example program in ``seatunnel-examples``, which can be directly called using ``seatunnel-flink-connector-v2-example`` or ``seatunnel-spark-connector-v2-example`` in ``SeaTunnelApiExample``. This is also the debugging method that is often used in the local development of Connector. The corresponding configuration files are saved in the same module ``resources/examples`` folder as before.
+We have prepared a new version of the locally executable example program in ``seatunnel-examples``, which can be
+directly called using ``seatunnel-flink-connector-v2-example`` or ``seatunnel-spark-connector-v2-example``
Review Comment:
> which can be
directly called using ``seatunnel-flink-connector-v2-example`` or ``seatunnel-spark-connector-v2-example``
in ``SeaTunnelApiExample``
One is `seatunnel-examples/seatunnel-flink-connector-v2-example/src/main/java/org/apache/seatunnel/example/flink/v2/SeaTunnelApiExample.java`, it runs in the Flink engine. Another one is `seatunnel-examples/seatunnel-spark-connector-v2-example/src/main/java/org/apache/seatunnel/example/spark/v2/SeaTunnelApiExample.java`, it runs in the Spark engine.
##########
seatunnel-connectors-v2/README.md:
##########
@@ -1,48 +1,101 @@
# Purpose
-This article introduces the new interface and the new code structure on account of the newly designed API for Connectors in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and development of new Connector.
+
+This article introduces the new interface and the new code structure on account of the newly designed API for Connectors
Review Comment:
Can you link the proposal https://github.com/apache/incubator-seatunnel/issues/1608
##########
seatunnel-connectors-v2/README.md:
##########
@@ -1,48 +1,101 @@
# Purpose
-This article introduces the new interface and the new code structure on account of the newly designed API for Connectors in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and development of new Connector.
+
+This article introduces the new interface and the new code structure on account of the newly designed API for Connectors
+in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and
Review Comment:
`This helps developers quickly understand API and transformation layer improvements. On the other hand, it can guide contributors how to use the new API to develop new connectors.` is better.
##########
seatunnel-connectors-v2/README.md:
##########
@@ -1,48 +1,101 @@
# Purpose
-This article introduces the new interface and the new code structure on account of the newly designed API for Connectors in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and development of new Connector.
+
+This article introduces the new interface and the new code structure on account of the newly designed API for Connectors
+in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and
+development of new Connector.
## **Code Structure**
-In order to separate from the old code, we have defined new modules for execution flow. This facilitates parallel development at the current stage, and reduces the difficulty of merging. All the relevant code at this stage is kept on the ``api-draft`` branch.
+
+In order to separate from the old code, we have defined new modules for execution flow. This facilitates parallel
+development at the current stage, and reduces the difficulty of merging.
### **Example**
-We have prepared a new version of the locally executable example program in ``seatunnel-examples``, which can be directly called using ``seatunnel-flink-connector-v2-example`` or ``seatunnel-spark-connector-v2-example`` in ``SeaTunnelApiExample``. This is also the debugging method that is often used in the local development of Connector. The corresponding configuration files are saved in the same module ``resources/examples`` folder as before.
+We have prepared a new version of the locally executable example program in ``seatunnel-examples``, which can be
Review Comment:
> We have prepared a new version of the locally executable example program in ``seatunnel-examples``
We have prepared two new version of the locally executable example program in `seatunnel-examples`.
##########
seatunnel-connectors-v2/README.md:
##########
@@ -1,48 +1,101 @@
# Purpose
-This article introduces the new interface and the new code structure on account of the newly designed API for Connectors in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and development of new Connector.
+
+This article introduces the new interface and the new code structure on account of the newly designed API for Connectors
+in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and
+development of new Connector.
## **Code Structure**
-In order to separate from the old code, we have defined new modules for execution flow. This facilitates parallel development at the current stage, and reduces the difficulty of merging. All the relevant code at this stage is kept on the ``api-draft`` branch.
+
+In order to separate from the old code, we have defined new modules for execution flow. This facilitates parallel
+development at the current stage, and reduces the difficulty of merging.
### **Example**
-We have prepared a new version of the locally executable example program in ``seatunnel-examples``, which can be directly called using ``seatunnel-flink-connector-v2-example`` or ``seatunnel-spark-connector-v2-example`` in ``SeaTunnelApiExample``. This is also the debugging method that is often used in the local development of Connector. The corresponding configuration files are saved in the same module ``resources/examples`` folder as before.
+We have prepared a new version of the locally executable example program in ``seatunnel-examples``, which can be
+directly called using ``seatunnel-flink-connector-v2-example`` or ``seatunnel-spark-connector-v2-example``
+in ``SeaTunnelApiExample``. This is also the debugging method that is often used in the local development of Connector.
+The corresponding configuration files are saved in the same module ``resources/examples`` folder as before. Currently,
Review Comment:
> The corresponding configuration files are saved in the same module ``resources/examples`` folder as before
The configuration files used in example are saved in the "resources/examples" folder..
I think it is enough to clarify the location of the example configuration file. It is unnecessary to guide the user to understand the previous configuration.
##########
seatunnel-connectors-v2/README.md:
##########
@@ -1,48 +1,101 @@
# Purpose
-This article introduces the new interface and the new code structure on account of the newly designed API for Connectors in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and development of new Connector.
+
+This article introduces the new interface and the new code structure on account of the newly designed API for Connectors
+in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and
+development of new Connector.
## **Code Structure**
-In order to separate from the old code, we have defined new modules for execution flow. This facilitates parallel development at the current stage, and reduces the difficulty of merging. All the relevant code at this stage is kept on the ``api-draft`` branch.
+
+In order to separate from the old code, we have defined new modules for execution flow. This facilitates parallel
+development at the current stage, and reduces the difficulty of merging.
### **Example**
-We have prepared a new version of the locally executable example program in ``seatunnel-examples``, which can be directly called using ``seatunnel-flink-connector-v2-example`` or ``seatunnel-spark-connector-v2-example`` in ``SeaTunnelApiExample``. This is also the debugging method that is often used in the local development of Connector. The corresponding configuration files are saved in the same module ``resources/examples`` folder as before.
+We have prepared a new version of the locally executable example program in ``seatunnel-examples``, which can be
+directly called using ``seatunnel-flink-connector-v2-example`` or ``seatunnel-spark-connector-v2-example``
+in ``SeaTunnelApiExample``. This is also the debugging method that is often used in the local development of Connector.
+The corresponding configuration files are saved in the same module ``resources/examples`` folder as before. Currently,
+you need to add the dependencies of the corresponding connectors to the pom file for testing under the
+seatunnel-examples module, if there are some three-party dependencies, please add them to the module classpath by
+yourself, if the scope of some dependencies of the connectors is provided, you also need to set Include dependencies
+with Provided Scope in Intellij IDEA. .
### **Startup Class**
-Aside from the old startup class, we have created two new startup class projects, namely ``seatunnel-core/seatunnel-flink-starter`` and ``seatunnel-core/seatunnel-spark-starter``. You can find out how to parse the configuration file into an executable Flink/Spark process here.
Review Comment:
> Aside from the old startup class, we have created two new startup class projects
Aside from the old startup module, we have created two new startup modules.
##########
seatunnel-connectors-v2/README.md:
##########
@@ -1,48 +1,101 @@
# Purpose
-This article introduces the new interface and the new code structure on account of the newly designed API for Connectors in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and development of new Connector.
+
+This article introduces the new interface and the new code structure on account of the newly designed API for Connectors
+in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and
+development of new Connector.
## **Code Structure**
-In order to separate from the old code, we have defined new modules for execution flow. This facilitates parallel development at the current stage, and reduces the difficulty of merging. All the relevant code at this stage is kept on the ``api-draft`` branch.
+
+In order to separate from the old code, we have defined new modules for execution flow. This facilitates parallel
+development at the current stage, and reduces the difficulty of merging.
### **Example**
-We have prepared a new version of the locally executable example program in ``seatunnel-examples``, which can be directly called using ``seatunnel-flink-connector-v2-example`` or ``seatunnel-spark-connector-v2-example`` in ``SeaTunnelApiExample``. This is also the debugging method that is often used in the local development of Connector. The corresponding configuration files are saved in the same module ``resources/examples`` folder as before.
+We have prepared a new version of the locally executable example program in ``seatunnel-examples``, which can be
+directly called using ``seatunnel-flink-connector-v2-example`` or ``seatunnel-spark-connector-v2-example``
+in ``SeaTunnelApiExample``. This is also the debugging method that is often used in the local development of Connector.
+The corresponding configuration files are saved in the same module ``resources/examples`` folder as before. Currently,
+you need to add the dependencies of the corresponding connectors to the pom file for testing under the
Review Comment:
> you need to add the dependencies of the corresponding connectors to the pom file for testing under the
seatunnel-examples module, if there are some three-party dependencies, please add them to the module classpath by
yourself, if the scope of some dependencies of the connectors is provided, you also need to set Include dependencies
with Provided Scope in Intellij IDEA.
I think these are guidelines for contributors on how to add examples to their connectors. This requires clearer steps.
**If you want to add examples for your own connectors, you need to follow the steps below.**
1. Add the dependencies of the connector to be tested to `seatunnel-examples/seatunnel-flink-connector-v2-example/pom.xml`(or add it to `seatunnel-examples/seatunnel-spark-connector-v2-example/pom.xml` when you want to runs it in Spark engine).
2. Fink the dependency in your connector pom file which scope is `test` or `provided` and then add them to `seatunnel-examples/seatunnel-flink-connector-v2-example/pom.xml`(or add it to `seatunnel-examples/seatunnel-spark-connector-v2-example/pom.xml` file and modify the scope to compile.
3. Refer to the SeaTunnelApiExample class to develop your sample code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#issuecomment-1257097811
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on code in PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#discussion_r975552392
##########
seatunnel-connectors-v2/README.zh.md:
##########
@@ -1,11 +1,11 @@
## 目的
-Because SeaTunnel design new API for connectors, 所以通过这篇文章来介绍新的接口以及新的代码结构，方便开发者快速的帮助新API和翻译层完善，以及开发出新的Connecotor.
+因为SeaTunnel 为connectors设计了新的API，所以通过这篇文章来介绍新的接口以及新的代码结构，方便开发者快速的帮助新API和翻译层完善，以及开发出新的Connector.
## 代码结构
-现阶段所有相关代码保存在`api-draft`分支上。
为了和老的代码分开，方便现阶段的并行开发，以及降低merge的难度。我们为新的执行流程定义了新的模块
### Example
我们已经在`seatunnel-examples`中准备好了新版本的可本地执行Example程序，直接调用`seatunnel-flink-connector-v2-example`或`seatunnel-spark-connector-v2-example`中的`SeaTunnelApiExample`即可。这也是本地开发Connector经常会用到的调试方式。
-对应的配置文件保存在同模块的`resources/examples`文件夹下，和以前一样。
+对应的配置文件保存在同模块的`resources/examples`文件夹下，和以前一样。目前测试需要将connector依赖进来，如果有部分第三方包需要自行依赖请使用类加载器自行加载，如果有些 Scope为 Provided的依赖，需要在Intellij IDEAZ中单击 "Run"->"Edit configurations...",在
Review Comment:
目前在Example模块下测试需要把对应连接器的依赖添加到pom文件中，如果有部分三方依赖请自行添加至模块classpath，如果连接器的某些依赖的`scope`为`provided`，则还需要在Intellij IDEA中设置`Include dependencies with Provided Scope`
##########
seatunnel-connectors-v2/README.md:
##########
@@ -79,6 +80,6 @@ It is used to process ``SinkWriter.prepareCommit`` the returned data information
In the current version, it is recommended to implement ``SinkAggregatedCommitter`` as the first choice, which can provide strong consistency guarantee in Flink/Spark. At the same time, commit should be idempotent, and save engine retry can work normally.
Review Comment:
SeaTunnel has designed a new connector API to decouple from the compute engine. This article introduces the new interface and the new code structure to help developers quickly get started with the new API and understand the principles of the new API.
##########
seatunnel-connectors-v2/README.zh.md:
##########
@@ -61,4 +61,4 @@ if (Boundedness.BOUNDED.equals(context.getBoundedness())) {
#### 我应该实现SinkCommitter还是SinkAggregatedCommitter？
当前版本推荐将实现SinkAggregatedCommitter作为首选，可以在Flink/Spark中提供较强的一致性保证，同时commit应该要实现幂等性，保存引擎重试能够正常运作。
## 实现
-所有的Connector实现都应该在`seatunnel-connectors/seatunnel-connectors-seatuunel`模块下，现阶段可参考的示例均在此模块下。
\ No newline at end of file
+所有的Connector实现都应该在`seatunnel-connectors-v2`模块下，现阶段可参考的示例均在此模块下。
Review Comment:
现阶段所有的连接器实现及可参考的示例都在`seatunnel-connectors-v2`下，用户可自行查阅参考
##########
seatunnel-connectors-v2/README.zh.md:
##########
@@ -1,11 +1,11 @@
## 目的
-Because SeaTunnel design new API for connectors, 所以通过这篇文章来介绍新的接口以及新的代码结构，方便开发者快速的帮助新API和翻译层完善，以及开发出新的Connecotor.
+因为SeaTunnel 为connectors设计了新的API，所以通过这篇文章来介绍新的接口以及新的代码结构，方便开发者快速的帮助新API和翻译层完善，以及开发出新的Connector.
Review Comment:
SeaTunnel为与计算引擎进行解耦，设计了新的连接器API，通过这篇文章来介绍新的接口以及新的代码结构，方便开发者快速上手使用新版API开发连接器并理解新版API运行原理
##########
seatunnel-connectors-v2/README.md:
##########
@@ -2,10 +2,11 @@
This article introduces the new interface and the new code structure on account of the newly designed API for Connectors in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and development of new Connector.
## **Code Structure**
-In order to separate from the old code, we have defined new modules for execution flow. This facilitates parallel development at the current stage, and reduces the difficulty of merging. All the relevant code at this stage is kept on the ``api-draft`` branch.
+In order to separate from the old code, we have defined new modules for execution flow. This facilitates parallel development at the current stage, and reduces the difficulty of merging.
### **Example**
We have prepared a new version of the locally executable example program in ``seatunnel-examples``, which can be directly called using ``seatunnel-flink-connector-v2-example`` or ``seatunnel-spark-connector-v2-example`` in ``SeaTunnelApiExample``. This is also the debugging method that is often used in the local development of Connector. The corresponding configuration files are saved in the same module ``resources/examples`` folder as before.
+For now, the test needs to rely on the Connector,if your test must use a third-party jar and the Scope is Provided,you need to check "Include dependencies with 'Provided Scope" and choose current Project in "Run"->"Edit configurations..."->"Use classpath of module" .
Review Comment:
Currently, you need to add the dependencies of the corresponding connectors to the pom file for testing under the `seatunnel-examples` module, if there are some three-party dependencies, please add them to the module classpath by yourself, if the scope of some dependencies of the connectors is `provided`, you also need to set `Include dependencies with Provided Scope` in Intellij IDEA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#issuecomment-1253534438
> @TyrantLucifer @EricJoy2048
PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#issuecomment-1253534220
@TyrantLucifer @EricJoy2048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on code in PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#discussion_r979241227
##########
seatunnel-connectors-v2/README.md:
##########
@@ -1,48 +1,101 @@
# Purpose
-This article introduces the new interface and the new code structure on account of the newly designed API for Connectors in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and development of new Connector.
+
+This article introduces the new interface and the new code structure on account of the newly designed API for Connectors
Review Comment:
Please link proposal here like the Chinese document.
##########
seatunnel-connectors-v2/README.zh.md:
##########
@@ -1,64 +1,127 @@
## 目的
-Because SeaTunnel design new API for connectors, 所以通过这篇文章来介绍新的接口以及新的代码结构，方便开发者快速的帮助新API和翻译层完善，以及开发出新的Connecotor.
+
+因为SeaTunnel 为connectors设计了新的API，所以通过这篇文章来介绍新的接口以及新的代码结构，方便开发者快速的帮助新API和翻译层完善，以及开发出新的Connector.
+详细设计请查看该[提议](https://github.com/apache/incubator-seatunnel/issues/1608) 。
+
## 代码结构
-现阶段所有相关代码保存在`api-draft`分支上。
+
为了和老的代码分开，方便现阶段的并行开发，以及降低merge的难度。我们为新的执行流程定义了新的模块
+
### Example
-我们已经在`seatunnel-examples`中准备好了新版本的可本地执行Example程序，直接调用`seatunnel-flink-connector-v2-example`或`seatunnel-spark-connector-v2-example`中的`SeaTunnelApiExample`即可。这也是本地开发Connector经常会用到的调试方式。
-对应的配置文件保存在同模块的`resources/examples`文件夹下，和以前一样。
+
+我们已经在`seatunnel-examples`
+准备了两个本地可执行的案例程序,其中一个是`seatunnel-examples/seatunnel-flink-connector-v2-example/src/main/java/org/apache/seatunnel/example/flink/v2/SeaTunnelApiExample.java`
+，它运行在flink引擎上。另外一个是`seatunnel-examples/seatunnel-spark-connector-v2-example/src/main/java/org/apache/seatunnel/example/spark/v2/SeaTunnelApiExample.java`
+，它运行在spark引擎上。你可以通过调试这些例子帮你更好的理解程序运行逻辑。使用的配置文件保存在`resources/examples`文件夹里。如果你想增加自己的connectors，你需要按照下面的步骤。
+
+1. 在`seatunnel-examples/seatunnel-flink-connector-v2-example/pom.xml`添加connector依赖的groupId, artifactId 和
+ version.（或者当你想在spark引擎运行时在`seatunnel-examples/seatunnel-spark-connector-v2-example/pom.xml`添加依赖）
+2. 如果你的connector存在scope为test或者provided的依赖则在`seatunnel-examples/seatunnel-flink-connector-v2-example/pom.xml`(
+ 或者在`seatunnel-examples/seatunnel-spark-connector-v2-example/pom.xml`)修改为compile。
+3. 参考`SeaTunnelApiExample`开发自己的案例程序。
+
### 启动类
-和老的启动类分开，我们创建了两个新的启动类工程，分别是`seatunnel-core/seatunnel-flink-starter`和`seatunnel-core/seatunnel-spark-starter`. 可以在这里找到如何将配置文件解析为可以执行的Flink/Spark流程。
+
+和老的启动类分开，我们创建了两个新的启动类工程，分别是`seatunnel-core/seatunnel-flink-starter`和`seatunnel-core/seatunnel-spark-starter`.
+可以在这里找到如何将配置文件解析为可以执行的Flink/Spark流程。
+
### SeaTunnel API
+
新建了一个`seatunnel-api`(不是`seatunnel-apis`)模块，用于存放SeaTunnel API定义的新接口, 开发者通过对这些接口进行实现，就可以完成支持多引擎的SeaTunnel Connector
+
### 翻译层
-我们通过适配不同引擎的接口，实现SeaTunnel API和Engine API的转换，从而达到翻译的效果，让我们的SeaTunnel Connector支持多个不同引擎的运行。
-对应代码地址为`seatunnel-translation`,该模块有对应的翻译层实现。感兴趣可以查看代码，帮助我们完善当前代码。
+
+我们通过适配不同引擎的接口，实现SeaTunnel API和Engine API的转换，从而达到翻译的效果，让我们的SeaTunnel Connector支持多个不同引擎的运行。 对应代码地址为`seatunnel-translation`
+,该模块有对应的翻译层实现。感兴趣可以查看代码，帮助我们完善当前代码。
+
## API 介绍
+
`SeaTunnel 当前版本的API设计借鉴了Flink的设计理念`
+
### Source
+
#### SeaTunnelSource.java
-- SeaTunnel的Source采用流批一体的设计，通过`getBoundedness`来决定当前Source是流Source还是批Source，所以可以通过动态配置的方式（参考default方法）来指定一个Source既可以为流，也可以为批。
+
+- SeaTunnel的Source采用流批一体的设计，通过`getBoundedness`
+ 来决定当前Source是流Source还是批Source，所以可以通过动态配置的方式（参考default方法）来指定一个Source既可以为流，也可以为批。
- `getRowTypeInfo`来得到数据的schema，connector可以选择硬编码来实现固定的schema，或者运行用户通过config配置来自定义schema，推荐后者。
- SeaTunnelSource是执行在driver端的类，通过该类，来获取SourceReader，SplitEnumerator等对象以及序列化器。
- 目前SeaTunnelSource支持的生产的数据类型必须是SeaTunnelRow类型。
+
#### SourceSplitEnumerator.java
+
通过该枚举器来获取数据读取的分片（SourceSplit）情况，不同的分片可能会分配给不同的SourceReader来读取数据。包含几个关键方法：
+
- `run`用于执行产生SourceSplit并调用`SourceSplitEnumerator.Context.assignSplit`来将分片分发给SourceReader。
- `addSplitsBack`用于处理SourceReader异常导致SourceSplit无法正常处理或者重启时，需要SourceSplitEnumerator对这些Split进行重新分发。
-- `registerReader`处理一些在run运行了之后才注册上的SourceReader，如果这个时候还没有分发下去的SourceSplit，就可以分发给这些新的Reader（对，你大多数时候需要在SourceSplitEnumerator里面维护你的SourceSplit分发情况）
-- `handleSplitRequest`如果有些Reader主动向SourceSplitEnumerator请求SourceSplit，那么可以通过该方法调用`SourceSplitEnumerator.Context.assignSplit`来向对应的Reader发送分片。
-- `snapshotState`用于流处理定时返回需要保存的当前状态，如果有状态恢复时，会调用`SeaTunnelSource.restoreEnumerator`来构造SourceSplitEnumerator，将保存的状态恢复给SourceSplitEnumerator。
+- `registerReader`
+ 处理一些在run运行了之后才注册上的SourceReader，如果这个时候还没有分发下去的SourceSplit，就可以分发给这些新的Reader（对，你大多数时候需要在SourceSplitEnumerator里面维护你的SourceSplit分发情况）
+- `handleSplitRequest`
+ 如果有些Reader主动向SourceSplitEnumerator请求SourceSplit，那么可以通过该方法调用`SourceSplitEnumerator.Context.assignSplit`来向对应的Reader发送分片。
+- `snapshotState`用于流处理定时返回需要保存的当前状态，如果有状态恢复时，会调用`SeaTunnelSource.restoreEnumerator`
+ 来构造SourceSplitEnumerator，将保存的状态恢复给SourceSplitEnumerator。
- `notifyCheckpointComplete`用于状态保存成功后的后续处理，可以用于将状态或者标记存入第三方存储。
+
#### SourceSplit.java
+
用于保存分片的接口，不同的分片需要定义不同的splitId，可以通过实现这个接口，保存分片需要保存的数据，比如kafka的partition和topic，hbase的columnfamily等信息，用于SourceReader来确定应该读取全部数据的哪一部分。
+
#### SourceReader.java
+
直接和数据源进行交互的接口，通过实现该接口完成从数据源读取数据的动作。
-- `pollNext`便是Reader的核心，通过这个接口，实现读取数据源的数据然后返回给SeaTunnel的流程。每当准备将数据传递给SeaTunnel时，就可以调用参数中的`Collector.collect`方法，可以无限次的调用该方法完成数据的大量读取。但是现阶段支持的数据格式只能是`SeaTunnelRow`。因为我们的Source是流批一体的，所以批模式的时候Connector要自己决定什么时候结束数据读取，比如批处理一次读取100条数据，读取完成后需要在`pollNext`中调用`SourceReader.Context.signalNoMoreElement`通知SeaTunnel没有数据读取了，那么就可以利用这100条数据进行批处理。流处理没有这个要求，那么大多数流批一体的SourceReader都会出现如下代码：
+
+- `pollNext`便是Reader的核心，通过这个接口，实现读取数据源的数据然后返回给SeaTunnel的流程。每当准备将数据传递给SeaTunnel时，就可以调用参数中的`Collector.collect`
+ 方法，可以无限次的调用该方法完成数据的大量读取。但是现阶段支持的数据格式只能是`SeaTunnelRow`
+ 。因为我们的Source是流批一体的，所以批模式的时候Connector要自己决定什么时候结束数据读取，比如批处理一次读取100条数据，读取完成后需要在`pollNext`
+ 中调用`SourceReader.Context.signalNoMoreElement`
+ 通知SeaTunnel没有数据读取了，那么就可以利用这100条数据进行批处理。流处理没有这个要求，那么大多数流批一体的SourceReader都会出现如下代码：
+
```java
-if (Boundedness.BOUNDED.equals(context.getBoundedness())) {
+if(Boundedness.BOUNDED.equals(context.getBoundedness())){
Review Comment:
if (Boundedness.BOUNDED.equals(context.getBoundedness())) {
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#issuecomment-1256962104
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#discussion_r975225675
##########
seatunnel-connectors-v2/README.zh.md:
##########
@@ -61,4 +61,4 @@ if (Boundedness.BOUNDED.equals(context.getBoundedness())) {
#### 我应该实现SinkCommitter还是SinkAggregatedCommitter？
当前版本推荐将实现SinkAggregatedCommitter作为首选，可以在Flink/Spark中提供较强的一致性保证，同时commit应该要实现幂等性，保存引擎重试能够正常运作。
## 实现
-所有的Connector实现都应该在`seatunnel-connectors/seatunnel-connectors-seatuunel`模块下，现阶段可参考的示例均在此模块下。
\ No newline at end of file
+所有的Connector实现都应该在`seatunnel-connectors/seatunnel-connectors-seatuunel`模块下，现阶段可参考的示例均在此模块下。
Review Comment:
```suggestion
所有的Connector实现都应该在`seatunnel-connectors-v2`模块下，现阶段可参考的示例均在此模块下。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on code in PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#discussion_r979240858
##########
seatunnel-connectors-v2/README.zh.md:
##########
@@ -1,11 +1,11 @@
## 目的
-Because SeaTunnel design new API for connectors, 所以通过这篇文章来介绍新的接口以及新的代码结构，方便开发者快速的帮助新API和翻译层完善，以及开发出新的Connecotor.
+因为SeaTunnel 为connectors设计了新的API，所以通过这篇文章来介绍新的接口以及新的代码结构，方便开发者快速的帮助新API和翻译层完善，以及开发出新的Connector.
Review Comment:
Who not change it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on code in PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#discussion_r975559975
##########
seatunnel-connectors-v2/README.md:
##########
@@ -2,10 +2,11 @@
This article introduces the new interface and the new code structure on account of the newly designed API for Connectors in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and development of new Connector.
Review Comment:
SeaTunnel has designed a new connector API to decouple from the compute engine. This article introduces the new interface and the new code structure to help developers quickly get started with the new API and understand the principles of the new API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#issuecomment-1253175845
That's great.
Thank you for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer merged pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
TyrantLucifer merged PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#issuecomment-1252269739
PTAL @Hisoka-X
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#issuecomment-1256867673
#2873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2800: [Improve][DOC] Perfect the connector v2 doc
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#discussion_r979215481
##########
seatunnel-connectors-v2/README.md:
##########
@@ -1,48 +1,101 @@
# Purpose
-This article introduces the new interface and the new code structure on account of the newly designed API for Connectors in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and development of new Connector.
+
+This article introduces the new interface and the new code structure on account of the newly designed API for Connectors
+in Apache SeaTunnel. This helps developers with quick overview regarding API, translation layer improvement, and
+development of new Connector.
## **Code Structure**
-In order to separate from the old code, we have defined new modules for execution flow. This facilitates parallel development at the current stage, and reduces the difficulty of merging. All the relevant code at this stage is kept on the ``api-draft`` branch.
+
+In order to separate from the old code, we have defined new modules for execution flow. This facilitates parallel
+development at the current stage, and reduces the difficulty of merging.
### **Example**
-We have prepared a new version of the locally executable example program in ``seatunnel-examples``, which can be directly called using ``seatunnel-flink-connector-v2-example`` or ``seatunnel-spark-connector-v2-example`` in ``SeaTunnelApiExample``. This is also the debugging method that is often used in the local development of Connector. The corresponding configuration files are saved in the same module ``resources/examples`` folder as before.
+We have prepared a new version of the locally executable example program in ``seatunnel-examples``, which can be
+directly called using ``seatunnel-flink-connector-v2-example`` or ``seatunnel-spark-connector-v2-example``
+in ``SeaTunnelApiExample``. This is also the debugging method that is often used in the local development of Connector.
+The corresponding configuration files are saved in the same module ``resources/examples`` folder as before. Currently,
+you need to add the dependencies of the corresponding connectors to the pom file for testing under the
Review Comment:
> you need to add the dependencies of the corresponding connectors to the pom file for testing under the
seatunnel-examples module, if there are some three-party dependencies, please add them to the module classpath by
yourself, if the scope of some dependencies of the connectors is provided, you also need to set Include dependencies
with Provided Scope in Intellij IDEA.
I think these are guidelines for contributors on how to add examples to their connectors. This requires clearer steps.
**If you want to add examples for your own connectors, you need to follow the steps below.**
1. Add the `groupId`, `artifactId` and `version` of the connector to be tested to `seatunnel-examples/seatunnel-flink-connector-v2-example/pom.xml`(or add it to `seatunnel-examples/seatunnel-spark-connector-v2-example/pom.xml` when you want to runs it in Spark engine) as a dependency.
2. Find the dependency in your connector pom file which scope is `test` or `provided` and then add them to `seatunnel-examples/seatunnel-flink-connector-v2-example/pom.xml`(or add it to `seatunnel-examples/seatunnel-spark-connector-v2-example/pom.xml` file and modify the scope to compile.
3. Refer to the SeaTunnelApiExample class to develop your sample code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org