You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mahesh Bandal <ma...@gmail.com> on 2020/08/06 06:02:00 UTC
Re: Review Request 72702: RANGER-2923: Changing data type of
sync_source_info column to accommodate more characters
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72702/
-----------------------------------------------------------
(Updated Aug. 6, 2020, 6:01 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-2923
https://issues.apache.org/jira/browse/RANGER-2923
Repository: ranger
Description
-------
Insert values for the column "sync_source_info" under table "x_ugsync_audit_info" can go beyond the maximum length of column. (currently limit is VARCHAR 4000).
Now changing data type to different db flavours as follows :
mysql : VARCHAR => MEDIUMTEXT
oracle : VARCHAR => CLOB
postgres : VARCHAR => TEXT
sqlanywhere : VARCHAR => TEXT
sqlserver : VARCHAR => nvarchar(max)
Diffs (updated)
-----
security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 832d650cf
security-admin/db/mysql/patches/048-alter-sync-source-info-in-x-ugsync-audit-info.sql PRE-CREATION
security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 4576e9677
security-admin/db/oracle/patches/048-alter-sync-source-info-in-x-ugsync-audit-info.sql PRE-CREATION
security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 6a0941ff6
security-admin/db/postgres/patches/048-alter-sync-source-info-in-x-ugsync-audit-info.sql PRE-CREATION
security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql b663f3b02
security-admin/db/sqlanywhere/patches/048-alter-sync-source-info-in-x-ugsync-audit-info.sql PRE-CREATION
security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql ab370ffb1
security-admin/db/sqlserver/patches/048-alter-sync-source-info-in-x-ugsync-audit-info.sql PRE-CREATION
Diff: https://reviews.apache.org/r/72702/diff/3/
Changes: https://reviews.apache.org/r/72702/diff/2-3/
Testing
-------
Inserted large values of more than 4000 characters in column "sync_source_info" under table "x_ugsync_audit_info". Insert query succeeds.
Thanks,
Mahesh Bandal
Re: Review Request 72702: RANGER-2923: Changing data type of
sync_source_info column to accommodate more characters
Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72702/#review221519
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On Aug. 6, 2020, 6:01 a.m., Mahesh Bandal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72702/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2020, 6:01 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2923
> https://issues.apache.org/jira/browse/RANGER-2923
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Insert values for the column "sync_source_info" under table "x_ugsync_audit_info" can go beyond the maximum length of column. (currently limit is VARCHAR 4000).
>
> Now changing data type to different db flavours as follows :
>
> mysql : VARCHAR => MEDIUMTEXT
>
> oracle : VARCHAR => CLOB
>
> postgres : VARCHAR => TEXT
>
> sqlanywhere : VARCHAR => TEXT
>
> sqlserver : VARCHAR => nvarchar(max)
>
>
> Diffs
> -----
>
> security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 832d650cf
> security-admin/db/mysql/patches/048-alter-sync-source-info-in-x-ugsync-audit-info.sql PRE-CREATION
> security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 4576e9677
> security-admin/db/oracle/patches/048-alter-sync-source-info-in-x-ugsync-audit-info.sql PRE-CREATION
> security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 6a0941ff6
> security-admin/db/postgres/patches/048-alter-sync-source-info-in-x-ugsync-audit-info.sql PRE-CREATION
> security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql b663f3b02
> security-admin/db/sqlanywhere/patches/048-alter-sync-source-info-in-x-ugsync-audit-info.sql PRE-CREATION
> security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql ab370ffb1
> security-admin/db/sqlserver/patches/048-alter-sync-source-info-in-x-ugsync-audit-info.sql PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72702/diff/3/
>
>
> Testing
> -------
>
> Inserted large values of more than 4000 characters in column "sync_source_info" under table "x_ugsync_audit_info". Insert query succeeds.
>
>
> Thanks,
>
> Mahesh Bandal
>
>