You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/27 12:33:32 UTC

[GitHub] [incubator-nuttx] juniskane opened a new pull request #2139: Ssd1306 cleanup

juniskane opened a new pull request #2139:
URL: https://github.com/apache/incubator-nuttx/pull/2139


   ## Summary
   Code cleanup for SSD1306 OLED driver:
   - some comments edited for typos and other obvious corrections
   - some commented out code removed
   - references to non-existent CONFIG* macros removed/corrected to real ones
   - one accidental #ifdef LCD_SSD1306_SPI changed to #ifdef CONFIG_LCD_SSD1306_SPI 
     (only affects compile-time pre-processor checks)
   - fix one DEBUGASSERT (checked ptr != NULL after dereferencing the ptr)
   - nxstyle changes
   
   ## Impact
   No functional change
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d commented on pull request #2139: Ssd1306 cleanup

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2139:
URL: https://github.com/apache/incubator-nuttx/pull/2139#issuecomment-717249246


   Looks good.
   BTW, I remember reading that your ICLA submission (as well as Haltian's SGA) was needed to clear a bunch of files, I'm not sure if you read it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d commented on pull request #2139: Ssd1306 cleanup

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2139:
URL: https://github.com/apache/incubator-nuttx/pull/2139#issuecomment-718134933


   Yes, my comment is unrelated to this change. I just wanted to ask @juniskane about this. Feel free to merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2139: Ssd1306 cleanup

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2139:
URL: https://github.com/apache/incubator-nuttx/pull/2139#issuecomment-718129823


   @v01d should we merge this PR? this patch don't have any real functional change, I don't think this type of change need to get ICLA or SGA. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2139: Ssd1306 cleanup

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2139:
URL: https://github.com/apache/incubator-nuttx/pull/2139


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org