You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/09 17:33:59 UTC

[jira] [Commented] (KAFKA-4516) When a CachingStateStore is closed it should clear its associated NamedCache. Subsequent queries should throw InvalidStateStoreException

    [ https://issues.apache.org/jira/browse/KAFKA-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735855#comment-15735855 ] 

ASF GitHub Bot commented on KAFKA-4516:
---------------------------------------

GitHub user dguy opened a pull request:

    https://github.com/apache/kafka/pull/2235

    KAFKA-4516: When a CachingStateStore is closed it should clear its associated NamedCache

    Clear and remove the NamedCache from the ThreadCache when a CachingKeyValueStore or CachingWindowStore is closed.
    Validate that the store is open when doing any queries or writes to Caching State Stores.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dguy/kafka kafka-4516

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2235.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2235
    
----
commit cfb2bffe8492b2da1f7ec06796d66ae59b720175
Author: Damian Guy <da...@gmail.com>
Date:   2016-12-09T17:31:19Z

    clear caches when store is closed

----


> When a CachingStateStore is closed it should clear its associated NamedCache. Subsequent queries should throw InvalidStateStoreException
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-4516
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4516
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 0.10.1.0
>            Reporter: Damian Guy
>            Assignee: Damian Guy
>             Fix For: 0.10.2.0
>
>
> When close is called on a CachingStateStore we don't release the memory it is using in the Cache. This could result in the cache being full of data that is redundant. We also still allow queries on the CachedStateStore even though it has been closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)