You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Apache Spark (JIRA)" <ji...@apache.org> on 2018/09/21 05:19:00 UTC

[jira] [Commented] (SPARK-25499) Refactor BenchmarkBase and Benchmark

    [ https://issues.apache.org/jira/browse/SPARK-25499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623084#comment-16623084 ] 

Apache Spark commented on SPARK-25499:
--------------------------------------

User 'gengliangwang' has created a pull request for this issue:
https://github.com/apache/spark/pull/22513

> Refactor BenchmarkBase and Benchmark
> ------------------------------------
>
>                 Key: SPARK-25499
>                 URL: https://issues.apache.org/jira/browse/SPARK-25499
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SQL
>    Affects Versions: 2.4.0
>            Reporter: Gengliang Wang
>            Priority: Major
>
> Currently there are two classes with the same naming BenchmarkBase:
> 1. org.apache.spark.util.BenchmarkBase
> 2. org.apache.spark.sql.execution.benchmark.BenchmarkBase
> Here I propose:
> 1. the package org.apache.spark.util.BenchmarkBase should be in test package, move to org.apache.spark.sql.execution.benchmark .
> 2. Rename the org.apache.spark.sql.execution.benchmark.BenchmarkBase as BenchmarkWithCodegen
> 3. Move  org.apache.spark.util.Benchmark to test package of org.apache.spark.sql.execution.benchmark



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org