You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yao Xu (Code Review)" <ge...@cloudera.org> on 2018/05/21 13:29:30 UTC
[kudu-CR] KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key"
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10463
Change subject: KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key"
......................................................................
KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key"
tserver carashes on Scan when [lowerPrimaryKey, upperPrimary)
and predicates of primary column do not overlap
Change-Id: I70326a52f2c693cd1b51d187f469eb8b1b0352a7
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M src/kudu/common/scan_spec-test.cc
M src/kudu/common/scan_spec.cc
3 files changed, 66 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/10463/1
--
To view, visit http://gerrit.cloudera.org:8080/10463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70326a52f2c693cd1b51d187f469eb8b1b0352a7
Gerrit-Change-Number: 10463
Gerrit-PatchSet: 1
Gerrit-Owner: Yao Xu <oc...@gmail.com>
[kudu-CR] KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key"
Posted by "Yao Xu (Code Review)" <ge...@cloudera.org>.
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/10463 )
Change subject: KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key"
......................................................................
Patch Set 1:
Ok, thanks Todd, I will fix this
--
To view, visit http://gerrit.cloudera.org:8080/10463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70326a52f2c693cd1b51d187f469eb8b1b0352a7
Gerrit-Change-Number: 10463
Gerrit-PatchSet: 1
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Comment-Date: Tue, 22 May 2018 02:16:16 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key"
Posted by "Yao Xu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10463
to look at the new patch set (#2).
Change subject: KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key"
......................................................................
KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key"
tserver crashes on Scan when [lowerPrimaryKey, upperPrimary)
and predicates of primary column do not overlap
Change-Id: I70326a52f2c693cd1b51d187f469eb8b1b0352a7
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M src/kudu/common/scan_spec-test.cc
M src/kudu/common/scan_spec.cc
3 files changed, 67 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/10463/2
--
To view, visit http://gerrit.cloudera.org:8080/10463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I70326a52f2c693cd1b51d187f469eb8b1b0352a7
Gerrit-Change-Number: 10463
Gerrit-PatchSet: 2
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
[kudu-CR] KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key"
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10463 )
Change subject: KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key"
......................................................................
Patch Set 1:
(1 comment)
Looks like the newly added test failed, can you take a look?
Also I think Dan Burkert is the best person to look at this, but I think he is out on vacation this week. Would it be OK if we wait for him to get back?
http://gerrit.cloudera.org:8080/#/c/10463/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10463/1//COMMIT_MSG@9
PS1, Line 9: tserver carashes on Scan when [lowerPrimaryKey, upperPrimary)
typo: "crashes"
--
To view, visit http://gerrit.cloudera.org:8080/10463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70326a52f2c693cd1b51d187f469eb8b1b0352a7
Gerrit-Change-Number: 10463
Gerrit-PatchSet: 1
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 21 May 2018 16:16:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key"
Posted by "Yao Xu (Code Review)" <ge...@cloudera.org>.
Yao Xu has abandoned this change. ( http://gerrit.cloudera.org:8080/10463 )
Change subject: KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key"
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/10463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I70326a52f2c693cd1b51d187f469eb8b1b0352a7
Gerrit-Change-Number: 10463
Gerrit-PatchSet: 3
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>