[GitHub] [bigtop] iwasakims commented on pull request #776: BIGTOP-3540. Building Spark fails on CentOS 7.

[GitBox <gi...@apache.org>]

iwasakims commented on pull request #776:
URL: https://github.com/apache/bigtop/pull/776#issuecomment-843108293


   @sekikn On my local CentOS 7, the `install_r_packages` worked regradless of the patch. The fix looks just making the command fail if expected packages are not found. Does this really fix the build failure of Spark in CI?
   ```
   $ sudo /usr/bin/R -e "remove.packages(c('evaluate', 'rmarkdown', 'knitr', 'roxygen2', 'testthat', 'e1071'))"
   $ /usr/bin/R -e 'library("knitr", character.only=TRUE, logical.return=TRUE)'
   ...
   > library("knitr", character.only=TRUE, logical.return=TRUE)
   [1] FALSE
   Warning message:
   In library("knitr", character.only = TRUE, logical.return = TRUE) :
     there is no package called ‘knitr’
   
   
   $ ./gradlew toolchain
   ...
   Debug: Exec[install_r_packages](provider=posix): Executing '/usr/bin/R -e "install.packages(c('devtools', 'evaluate', 'rmarkdown', 'knitr', 'roxygen2', 'testthat', 'e1071'), repos = 'http://cran.r-project.org/')"'
   Debug: Executing '/usr/bin/R -e "install.packages(c('devtools', 'evaluate', 'rmarkdown', 'knitr', 'roxygen2', 'testthat', 'e1071'), repos = 'http://cran.r-project.org/')"'
   ...
   
   
   $ /usr/bin/R -e 'library("knitr", character.only=TRUE, logical.return=TRUE)'
   ...
   > library("knitr", character.only=TRUE, logical.return=TRUE)
   [1] TRUE
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org