You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/22 20:21:23 UTC
[GitHub] [airflow] ephraimbuddy opened a new pull request #18444: Revert "Fix task instance url in webserver utils"
ephraimbuddy opened a new pull request #18444:
URL: https://github.com/apache/airflow/pull/18444
Reverts apache/airflow#18418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy merged pull request #18444: Revert "Fix task instance url in webserver utils" and fix properly
Posted by GitBox <gi...@apache.org>.
ephraimbuddy merged pull request #18444:
URL: https://github.com/apache/airflow/pull/18444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #18444: Revert "Fix task instance url in webserver utils" and fix properly
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #18444:
URL: https://github.com/apache/airflow/pull/18444#discussion_r714724051
##########
File path: airflow/www/utils.py
##########
@@ -228,7 +228,7 @@ def task_instance_link(attr):
dag_id = attr.get('dag_id')
task_id = attr.get('task_id')
execution_date = attr.get('dag_run.execution_date') or attr.get('execution_date') or timezone.utcnow()
- url = url_for('Airflow.task', dag_id=dag_id, task_id=task_id, execution_date=execution_date)
+ url = url_for('Airflow.task', dag_id=dag_id, task_id=task_id, execution_date=execution_date.isoformat())
Review comment:
```suggestion
url = url_for('Airflow.task', dag_id=dag_id, task_id=task_id, execution_date=execution_date.isoformat())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18444: Revert "Fix task instance url in webserver utils" and fix properly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18444:
URL: https://github.com/apache/airflow/pull/18444#issuecomment-925742413
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #18444: Revert "Fix task instance url in webserver utils"
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #18444:
URL: https://github.com/apache/airflow/pull/18444#discussion_r714282887
##########
File path: airflow/www/utils.py
##########
@@ -228,7 +228,7 @@ def task_instance_link(attr):
dag_id = attr.get('dag_id')
task_id = attr.get('task_id')
execution_date = attr.get('dag_run.execution_date') or attr.get('execution_date') or timezone.utcnow()
- url = url_for('Airflow.task', dag_id=dag_id, task_id=task_id, execution_date=execution_date)
+ url = url_for('Airflow.task', dag_id=dag_id, task_id=task_id)
Review comment:
```suggestion
url = url_for('Airflow.task', dag_id=dag_id, task_id=task_id, execution_date=execution_date.isoformat())
```
This suggestion was not applied, I had thought I applied it, surprised that I didn't. https://github.com/apache/airflow/pull/18418#discussion_r713520604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org