[jira] Commented: (WSCOMMONS-543) Change in r887108 breaks design of org.apache.axis2.transport.base.datagram

["Andreas Veithen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WSCOMMONS-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870454#action_12870454 ] 

Andreas Veithen commented on WSCOMMONS-543:
-------------------------------------------

The proper solution for this issue is as follows: instead of letting the UDP code submit the SocketAddress to the abstract datagram classes (which then builds a DatagramOutTransportInfo instance from it), it should directly create the DatagramOutTransportInfo (with the right subclass, namely UDPOutTransportInfo), and submit that to the abstract datagram classes. Indeed, for Axis2, OutTransportInfo is the right abstraction to store information about the back channel. It is also interesting to see that since UDPOutTransportInfo extends DatagramOutTransportInfo, it both has a SocketAddress attribute and two attributes to store a hostname and port number. Usage of two different kinds of OutTransportInfo is also the cause for the code duplication in UDPSender#sendMessage.

> Change in r887108 breaks design of org.apache.axis2.transport.base.datagram
> ---------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-543
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-543
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: Transport
>            Reporter: Andreas Veithen
>            Priority: Blocker
>             Fix For: Transports 1.1
>
>
> The change in r887108 [1] introduced a dependency between the classes in org.apache.axis2.transport.base.datagram and SocketAddress. This badly breaks the design of these classes, since they are not only used for UDP (which is the only derived transport that uses SocketAddress). See also [2] and [3]. This needs to be fixed for the next release.
> [1] http://svn.apache.org/viewvc?rev=887108&view=rev
> [2] http://markmail.org/thread/ancuyeuxefi6ttnn
> [3] http://markmail.org/message/nls3mpg2g4ec3uq5

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.