You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/11/23 02:34:33 UTC

[GitHub] [incubator-linkis] casionone commented on a diff in pull request #3869: [feature]New alarm button of management console

casionone commented on code in PR #3869:
URL: https://github.com/apache/incubator-linkis/pull/3869#discussion_r1029975606


##########
linkis-public-enhancements/linkis-jobhistory/src/main/scala/org/apache/linkis/jobhistory/service/impl/JobHistoryQueryServiceImpl.scala:
##########
@@ -426,4 +426,8 @@ class JobHistoryQueryServiceImpl extends JobHistoryQueryService with Logging {
     count
   }
 
+  override def changeObserveInfoById(jobHistory: JobHistory): Unit = {
+    jobHistoryMapper.updateJobHistory(jobHistory)
+  }

Review Comment:
   batter to  only update observerinfo filed?  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org