You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jason Lai <ja...@jasonlai.net> on 2018/09/21 22:44:37 UTC
Re: Review Request 65812: Added an overloaded version of
`os::realpath` to stout
> On May 18, 2018, 10:08 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 51 (patched)
> > <https://reviews.apache.org/r/65812/diff/6/?file=2024593#file2024593line51>
> >
> > Any reason we need this parameter here? Can we just remove this parameter, and use `os::PATH_SEPARATOR` below?
Done.
> On May 18, 2018, 10:08 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 65 (patched)
> > <https://reviews.apache.org/r/65812/diff/6/?file=2024593#file2024593line65>
> >
> > No need for period for error messages.
Done
> On May 18, 2018, 10:08 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 88 (patched)
> > <https://reviews.apache.org/r/65812/diff/6/?file=2024593#file2024593line88>
> >
> > No need to specify `_separator`?
Dropped.
> On May 18, 2018, 10:08 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 99 (patched)
> > <https://reviews.apache.org/r/65812/diff/6/?file=2024593#file2024593line99>
> >
> > no need to specify `_separator` for both functions. They're the default value
Dropped.
> On May 18, 2018, 10:08 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 108-112 (patched)
> > <https://reviews.apache.org/r/65812/diff/6/?file=2024593#file2024593line108>
> >
> > Let's add a stout helper `os::readlink`:
> >
> > ```
> > Try<string> readlink(const string& path);
> > ```
I added https://reviews.apache.org/r/68804/ as the wrapper for this.
> On May 18, 2018, 10:08 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 130 (patched)
> > <https://reviews.apache.org/r/65812/diff/6/?file=2024593#file2024593line130>
> >
> > Ditto. No need for `_separator`
Dropped.
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review203430
-----------------------------------------------------------
On May 17, 2018, 1:07 a.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> -----------------------------------------------------------
>
> (Updated May 17, 2018, 1:07 a.m.)
>
>
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
>
>
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an overloaded version of `os::realpath` to stout.
>
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/realpath.hpp 31352cefc5b8d0ccd9af8f6dabdec4a959fded32
>
>
> Diff: https://reviews.apache.org/r/65812/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Lai
>
>