You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/26 04:23:39 UTC
[GitHub] [incubator-superset] rusackas commented on a change in pull request
#9389: Migrating unique BigNumber(/Total) controls
rusackas commented on a change in pull request #9389: Migrating unique BigNumber(/Total) controls
URL: https://github.com/apache/incubator-superset/pull/9389#discussion_r398310221
##########
File path: CONTRIBUTING.md
##########
@@ -1016,15 +1016,6 @@ The `metric` (or equivalent) and `timeseries_limit_metric` fields are all compos
The filter-box configuration references column names (via the `column` key) and optionally metric names (via the `metric` key) if sorting is defined.
-### Options
-
-| Field | Type | Notes |
-| ---------------------- | --------- | ------------------------------------ |
-| `compare_lag` | _number_ | The **Comparison Period Lag** widget |
-| `compare_suffix` | _string_ | The **Comparison suffix** widget |
-| `show_trend_line` | _boolean_ | The **Show Trend Line** widget |
-| `start_y_axis_at_zero` | _boolean_ | The **Start y-axis at 0** widget |
-
Review comment:
@kristw I'll just keep removing these things as the controls are moved out of `controls.js`, but let me know if you have thoughts on when/where NOT to do that, so I don't kill any useful documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org