[GitHub] [hbase] Apache9 commented on a change in pull request #996: HBASE-23655 Fix flaky TestRSGroupsKillRS: should wait the SCP to finish

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #996: HBASE-23655 Fix flaky TestRSGroupsKillRS: should wait the SCP to finish
URL: https://github.com/apache/hbase/pull/996#discussion_r364034596
 
 

 ##########
 File path: hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsKillRS.java
 ##########
 @@ -237,12 +238,12 @@ public void testLowerMetaGroupVersion() throws Exception{
     addGroup(groupName, groupRSCount);
 
     // move hbase:meta to meta_group
-    tableName = TableName.META_TABLE_NAME;
     Set<TableName> toAddTables = new HashSet<>();
-    toAddTables.add(tableName);
+    toAddTables.add(TableName.META_TABLE_NAME);
     rsGroupAdmin.moveTables(toAddTables, groupName);
-    assertTrue(rsGroupAdmin.getRSGroupInfo(groupName).getTables().contains(tableName));
-    TEST_UTIL.waitTableAvailable(tableName, 30000);
+    assertTrue(
+        rsGroupAdmin.getRSGroupInfo(groupName).getTables().contains(TableName.META_TABLE_NAME));
+    TEST_UTIL.waitUntilAllRegionsAssigned(TableName.META_TABLE_NAME, 30000);
 
 Review comment:
   Does this method work for meta table? I'm not sure, just asking. As lots of the methods in HBTU just read the meta table so can not be used to test meta table itself...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services