[GitHub] JaroslavTulach commented on a change in pull request #502: #270552: AbstractProjectClassPathImpl subtypes generally need to process Artifact.file to handle timestamped snapshots properly

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #502: #270552: AbstractProjectClassPathImpl subtypes generally need to process Artifact.file to handle timestamped snapshots properly
URL: https://github.com/apache/incubator-netbeans/pull/502#discussion_r181958387
 
 

 ##########
 File path: maven/src/org/netbeans/modules/maven/queries/RepositoryMavenCPProvider.java
 ##########
 @@ -179,7 +179,7 @@ private ClassPathImplementation createCompileCPI(MavenProject project, File bina
         items.add(ClassPathSupport.createResource(FileUtil.urlForArchiveOrDir(binary)));
         if (project != null) {
             for (Artifact s : project.getCompileArtifacts()) {
-                File file = s.getFile();
+                File file = s.getFile(); // TODO perhaps needs patching
 
 Review comment:
   I guess you should make your mind. There is nobody to answer that TODO question otherwise. Or am I wrong @mkleint?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists