You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@manifoldcf.apache.org by "Shinichiro Abe (JIRA)" <ji...@apache.org> on 2011/06/27 07:32:48 UTC

[jira] [Created] (CONNECTORS-215) Setting an environment variable of agent

Setting an environment variable of agent
----------------------------------------

                 Key: CONNECTORS-215
                 URL: https://issues.apache.org/jira/browse/CONNECTORS-215
             Project: ManifoldCF
          Issue Type: Improvement
          Components: Framework agents process
            Reporter: Shinichiro Abe
            Priority: Minor


When using "./executecommand.sh org.apache.manifoldcf.agents.AgentRun",
we should have an environment variable or script parameter.
(e.g. JVM heapsize of agent)
We need to modify executecommand.bat too. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-215) Setting an environment variable of agent

Posted by "Shinichiro Abe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056401#comment-13056401 ] 

Shinichiro Abe commented on CONNECTORS-215:
-------------------------------------------

r1140488.

> Setting an environment variable of agent
> ----------------------------------------
>
>                 Key: CONNECTORS-215
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-215
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process
>            Reporter: Shinichiro Abe
>            Priority: Minor
>         Attachments: CONNECTORS-215-bat.patch, CONNECTORS-215-sh.patch, CONNECTORS-215-trial.patch
>
>
> When using "./executecommand.sh org.apache.manifoldcf.agents.AgentRun",
> we should have an environment variable or script parameter.
> (e.g. JVM heapsize of agent)
> We need to modify executecommand.bat too. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CONNECTORS-215) Setting an environment variable of agent

Posted by "Shinichiro Abe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CONNECTORS-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shinichiro Abe resolved CONNECTORS-215.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: ManifoldCF 0.3

> Setting an environment variable of agent
> ----------------------------------------
>
>                 Key: CONNECTORS-215
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-215
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process
>            Reporter: Shinichiro Abe
>            Priority: Minor
>             Fix For: ManifoldCF 0.3
>
>         Attachments: CONNECTORS-215-bat.patch, CONNECTORS-215-sh.patch, CONNECTORS-215-trial.patch
>
>
> When using "./executecommand.sh org.apache.manifoldcf.agents.AgentRun",
> we should have an environment variable or script parameter.
> (e.g. JVM heapsize of agent)
> We need to modify executecommand.bat too. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-215) Setting an environment variable of agent

Posted by "Karl Wright (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055431#comment-13055431 ] 

Karl Wright commented on CONNECTORS-215:
----------------------------------------

This will work fine, but may be overkill.  The reason the -D switches are built using a special directory is because each connector might want to contribute some.  But for -Xmx and -Xms, there can only be one such switch, so having these be built from a directory seems unnecessary.  What do you think?


> Setting an environment variable of agent
> ----------------------------------------
>
>                 Key: CONNECTORS-215
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-215
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process
>            Reporter: Shinichiro Abe
>            Priority: Minor
>         Attachments: CONNECTORS-215-trial.patch
>
>
> When using "./executecommand.sh org.apache.manifoldcf.agents.AgentRun",
> we should have an environment variable or script parameter.
> (e.g. JVM heapsize of agent)
> We need to modify executecommand.bat too. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CONNECTORS-215) Setting an environment variable of agent

Posted by "Shinichiro Abe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CONNECTORS-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shinichiro Abe updated CONNECTORS-215:
--------------------------------------

    Attachment: CONNECTORS-215-trial.patch

Is it Okay?

> Setting an environment variable of agent
> ----------------------------------------
>
>                 Key: CONNECTORS-215
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-215
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process
>            Reporter: Shinichiro Abe
>            Priority: Minor
>         Attachments: CONNECTORS-215-trial.patch
>
>
> When using "./executecommand.sh org.apache.manifoldcf.agents.AgentRun",
> we should have an environment variable or script parameter.
> (e.g. JVM heapsize of agent)
> We need to modify executecommand.bat too. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-215) Setting an environment variable of agent

Posted by "Shinichiro Abe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056387#comment-13056387 ] 

Shinichiro Abe commented on CONNECTORS-215:
-------------------------------------------

Thank you.I've tested.I'll commit.

> Setting an environment variable of agent
> ----------------------------------------
>
>                 Key: CONNECTORS-215
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-215
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process
>            Reporter: Shinichiro Abe
>            Priority: Minor
>         Attachments: CONNECTORS-215-bat.patch, CONNECTORS-215-sh.patch, CONNECTORS-215-trial.patch
>
>
> When using "./executecommand.sh org.apache.manifoldcf.agents.AgentRun",
> we should have an environment variable or script parameter.
> (e.g. JVM heapsize of agent)
> We need to modify executecommand.bat too. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-215) Setting an environment variable of agent

Posted by "Karl Wright (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055492#comment-13055492 ] 

Karl Wright commented on CONNECTORS-215:
----------------------------------------

Having these options in a file is OK.  If you look at how Tomcat works, they use an environment variable, and if the variable is not present they set it to whatever defaults are required.  Either approach will do.  But if you decide to use a file, then I would suggest giving it an extension (e.g. "options.env") so people understand what kind of file it is.


> Setting an environment variable of agent
> ----------------------------------------
>
>                 Key: CONNECTORS-215
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-215
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process
>            Reporter: Shinichiro Abe
>            Priority: Minor
>         Attachments: CONNECTORS-215-trial.patch
>
>
> When using "./executecommand.sh org.apache.manifoldcf.agents.AgentRun",
> we should have an environment variable or script parameter.
> (e.g. JVM heapsize of agent)
> We need to modify executecommand.bat too. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CONNECTORS-215) Setting an environment variable of agent

Posted by "Shinichiro Abe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CONNECTORS-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shinichiro Abe updated CONNECTORS-215:
--------------------------------------

    Attachment: CONNECTORS-215-sh.patch

I've modified executecommand.sh.
But I dont know how to write bat command, so it didnt work well.Please teach me bat command.




> Setting an environment variable of agent
> ----------------------------------------
>
>                 Key: CONNECTORS-215
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-215
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process
>            Reporter: Shinichiro Abe
>            Priority: Minor
>         Attachments: CONNECTORS-215-sh.patch, CONNECTORS-215-trial.patch
>
>
> When using "./executecommand.sh org.apache.manifoldcf.agents.AgentRun",
> we should have an environment variable or script parameter.
> (e.g. JVM heapsize of agent)
> We need to modify executecommand.bat too. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CONNECTORS-215) Setting an environment variable of agent

Posted by "Shinichiro Abe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CONNECTORS-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shinichiro Abe updated CONNECTORS-215:
--------------------------------------

    Attachment: CONNECTORS-215-bat.patch

I've modified executecommand.bat.
Please review it.

> Setting an environment variable of agent
> ----------------------------------------
>
>                 Key: CONNECTORS-215
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-215
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process
>            Reporter: Shinichiro Abe
>            Priority: Minor
>         Attachments: CONNECTORS-215-bat.patch, CONNECTORS-215-sh.patch, CONNECTORS-215-trial.patch
>
>
> When using "./executecommand.sh org.apache.manifoldcf.agents.AgentRun",
> we should have an environment variable or script parameter.
> (e.g. JVM heapsize of agent)
> We need to modify executecommand.bat too. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-215) Setting an environment variable of agent

Posted by "Shinichiro Abe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055490#comment-13055490 ] 

Shinichiro Abe commented on CONNECTORS-215:
-------------------------------------------

OK, I agree that. It may need not to have a directory.
Does the following become simple?

OPTIONS=$(cat "$MCF_HOME"/processes/script/options)

"Options" file includes default value "-Xms256m -Xmx256m".(Is it necessary?) 

> Setting an environment variable of agent
> ----------------------------------------
>
>                 Key: CONNECTORS-215
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-215
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process
>            Reporter: Shinichiro Abe
>            Priority: Minor
>         Attachments: CONNECTORS-215-trial.patch
>
>
> When using "./executecommand.sh org.apache.manifoldcf.agents.AgentRun",
> we should have an environment variable or script parameter.
> (e.g. JVM heapsize of agent)
> We need to modify executecommand.bat too. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-215) Setting an environment variable of agent

Posted by "Karl Wright (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056357#comment-13056357 ] 

Karl Wright commented on CONNECTORS-215:
----------------------------------------

It looks OK to me, as long as you've tested it somewhere.


> Setting an environment variable of agent
> ----------------------------------------
>
>                 Key: CONNECTORS-215
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-215
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process
>            Reporter: Shinichiro Abe
>            Priority: Minor
>         Attachments: CONNECTORS-215-bat.patch, CONNECTORS-215-sh.patch, CONNECTORS-215-trial.patch
>
>
> When using "./executecommand.sh org.apache.manifoldcf.agents.AgentRun",
> we should have an environment variable or script parameter.
> (e.g. JVM heapsize of agent)
> We need to modify executecommand.bat too. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira