You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2017/02/08 12:15:31 UTC
Review Request 56441: Js errors appear when user try to delete
widgets from dashboard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56441/
-----------------------------------------------------------
Review request for Ambari and Andrii Tkach.
Bugs: AMBARI-19921
https://issues.apache.org/jira/browse/AMBARI-19921
Repository: ambari
Description
-------
* Open Dashboard
* Click on "Delete widget links" as fast as you can
* JS-errors appears:
{noformat}
Uncaught Error: <DS.StateManager:ember6511> could not respond to event didChangeData in state rootState.loaded.updated.uncommitted.
{noformat}
{noformat}
Uncaught TypeError: Cannot read property 'get' of null
{noformat}
Diffs
-----
ambari-web/app/templates/main/dashboard/widgets.hbs 8e04f1c
ambari-web/app/views/main/dashboard/widget.js cacac1a
ambari-web/app/views/main/dashboard/widgets.js 0c6b7aa
ambari-web/test/views/main/dashboard/widget_test.js 8582ad0
ambari-web/test/views/main/dashboard/widgets_test.js b2d154b
Diff: https://reviews.apache.org/r/56441/diff/
Testing
-------
20338 passing (22s)
153 pending
Thanks,
Oleg Nechiporenko
Re: Review Request 56441: Js errors appear when user try to delete
widgets from dashboard
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56441/#review164668
-----------------------------------------------------------
Ship it!
Ship It!
- Andrii Tkach
On Feb. 8, 2017, 12:15 p.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56441/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 12:15 p.m.)
>
>
> Review request for Ambari and Andrii Tkach.
>
>
> Bugs: AMBARI-19921
> https://issues.apache.org/jira/browse/AMBARI-19921
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Open Dashboard
> * Click on "Delete widget links" as fast as you can
> * JS-errors appears:
>
> {noformat}
> Uncaught Error: <DS.StateManager:ember6511> could not respond to event didChangeData in state rootState.loaded.updated.uncommitted.
> {noformat}
>
> {noformat}
> Uncaught TypeError: Cannot read property 'get' of null
> {noformat}
>
>
> Diffs
> -----
>
> ambari-web/app/templates/main/dashboard/widgets.hbs 8e04f1c
> ambari-web/app/views/main/dashboard/widget.js cacac1a
> ambari-web/app/views/main/dashboard/widgets.js 0c6b7aa
> ambari-web/test/views/main/dashboard/widget_test.js 8582ad0
> ambari-web/test/views/main/dashboard/widgets_test.js b2d154b
>
> Diff: https://reviews.apache.org/r/56441/diff/
>
>
> Testing
> -------
>
> 20338 passing (22s)
> 153 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>