[GitHub] [airflow] dossett commented on a change in pull request #4064: AIRFLOW-3149 Support dataproc cluster deletion on ERROR

[GitBox <gi...@apache.org>]

dossett commented on a change in pull request #4064: AIRFLOW-3149 Support dataproc cluster deletion on ERROR
URL: https://github.com/apache/airflow/pull/4064#discussion_r285689225
 
 

 ##########
 File path: airflow/contrib/operators/dataproc_operator.py
 ##########
 @@ -272,7 +307,7 @@ def _wait_for_done(self, service):
                 time.sleep(15)
 
     def _get_init_action_timeout(self):
-        match = re.match(r"^(\d+)(s|m)$", self.init_action_timeout)
+        match = re.match(r"^(\d+)([sm])$", self.init_action_timeout)
 
 Review comment:
   Possibly?  That would require some other substantive changes right below this line to handle the `d` and `h`.  My change was just to make the regex a little more standardized, but sometimes those can spill over to more substantive changes.  I would want to err on the side of making that a separate change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services