[GitHub] ChaiBapchya commented on a change in pull request #14082: Fix nd.pick large array issue

[GitBox <gi...@apache.org>]

ChaiBapchya commented on a change in pull request #14082: Fix nd.pick large array issue
URL: https://github.com/apache/incubator-mxnet/pull/14082#discussion_r255799692
 
 

 ##########
 File path: src/operator/tensor/broadcast_reduce_op.h
 ##########
 @@ -1172,18 +1172,18 @@ void L2NormComputeEx(const nnvm::NodeAttrs& attrs,
 template<int ndim, bool clip = true>
 struct pick {
   template<typename DType, typename IType>
-  MSHADOW_XINLINE static void Map(int i, DType* out, const DType* a,
-                                  const IType *idx, int M, int stride,
+  MSHADOW_XINLINE static void Map(index_t i, DType* out, const DType* a,
+                                  const IType *idx, size_t M, int stride,
 
 Review comment:
   Sure. i looked at other places where large array support was mentioned. It seemed that
   `index_t` was used where the variable is used as index
   and `size_t` was used otherwise. Hence I stuck to that. But I'll change it to avoid casting if that's what's useful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services