You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/07 19:56:06 UTC
[GitHub] [airflow] lperson opened a new pull request #13549: more specific error handling in undefined jinja variables rule
lperson opened a new pull request #13549:
URL: https://github.com/apache/airflow/pull/13549
1. Use regex to extract variable name from exception message
2. Specific handling for ValueError and TypeError
3. Defend against endless loop
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13549: more specific error handling in undefined jinja variables rule
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13549:
URL: https://github.com/apache/airflow/pull/13549#issuecomment-756347009
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13549: more specific error handling in undefined jinja variables rule
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13549:
URL: https://github.com/apache/airflow/pull/13549#issuecomment-756357756
Caan you add tests to avoid regression?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RosterIn commented on a change in pull request #13549: more specific error handling in undefined jinja variables rule
Posted by GitBox <gi...@apache.org>.
RosterIn commented on a change in pull request #13549:
URL: https://github.com/apache/airflow/pull/13549#discussion_r576406027
##########
File path: tests/upgrade/rules/test_undefined_jinja_varaibles.py
##########
@@ -190,9 +215,16 @@ def test_invalid_check(self):
"dict object['undefined'] NestedTemplateField=att1 NestedTemplateField=nested1",
"Possible UndefinedJinjaVariable -> DAG: test-undefined-jinja-variables, "
"Task: templated_string, Attribute: env, Error: no such element: dict object['element']",
+ "Possible UndefinedJinjaVariable -> DAG: test-undefined-jinja-variables, "
+ "Task: miscellaneous_exception, Attribute: bash_command, "
+ "Error: 'NoneType' object is not iterable",
Review comment:
```suggestion
"Error: 'NoneType' object is not iterable, "
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13549: more specific error handling in undefined jinja variables rule
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13549:
URL: https://github.com/apache/airflow/pull/13549#issuecomment-780554346
We removed this check in 1.2.0 of upgrade-check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed pull request #13549: more specific error handling in undefined jinja variables rule
Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #13549:
URL: https://github.com/apache/airflow/pull/13549
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org