[jira] [Commented] (CB-1453) Namespace issue of JSONKit (JSONKitSerializingBlockAdditions)

["Shazron Abdullah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454383#comment-13454383 ] 

Shazron Abdullah commented on CB-1453:
--------------------------------------

Are you looking at the right source? I see that Category as already namespaced in the source:
https://github.com/apache/incubator-cordova-ios/blob/26a5b13ad3f08c3e4a7d4dc75b0a24d866d25323/CordovaLib/Classes/JSON/JSONKit.h#L237-240

The only issue I see is that it is prefixed cdv instead of cdvjk - but it should be harmless.



 
                
> Namespace issue of JSONKit (JSONKitSerializingBlockAdditions)
> -------------------------------------------------------------
>
>                 Key: CB-1453
>                 URL: https://issues.apache.org/jira/browse/CB-1453
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: 2.1.0
>         Environment: iOS
>            Reporter: Christoph Jerolimov
>
> In CB-1000 you've changed the namespace handling for the included library. But you missed this Category. So the build run still into duplicate warnings:
> {code}
> @interface NSDictionary (JSONKitSerializingBlockAdditions)
> - (NSData *)JSONDataWithOptions:(JKSerializeOptionFlags)serializeOptions serializeUnsupportedClassesUsingBlock:(id(^)(id object))block error:(NSError **)error;
> - (NSString *)JSONStringWithOptions:(JKSerializeOptionFlags)serializeOptions serializeUnsupportedClassesUsingBlock:(id(^)(id object))block error:(NSError **)error;
> @end
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira