[BCEL] Do we need BCEL-262 for 6.0? (Was: [VOTE] Release Apache Commons BCEL 6.0 based on RC6)

[Benedikt Ritter <br...@apache.org>]

Hi,

as pointed out by Mark Roberts, BCEL-262 is unresolved. Do we need it for
6.0 or can we live with the workaround and fix it for 6.1? It won't take
another 10 years for 6.1, promise! :-)

Benedikt

---------- Forwarded message ---------
From: Mark Roberts <ma...@cs.washington.edu>
Date: Mi., 22. Juni 2016 um 00:37 Uhr
Subject: RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC6
To: Commons Developers List <de...@commons.apache.org>


Thanks to sebb's suggestion of using shade I was able to test RC6.

Unfortunately, I am unable to vote as rev 1747124 breaks Daikon.  (We are
required to build with -Werror).  This change is not in the active tree so
that's good.  The problem is that
https://issues.apache.org/jira/browse/BCEL-262 is unresolved.  There is a
suggested workaround for the deprecation, but it is very awkward:
invoke.getClassName(pool) versus
invoke.getReferenceType(pool).getClass().getName()

Thanks,
Mark


> -----Original Message-----
> From: Benedikt Ritter [mailto:britter@apache.org]
> Sent: Monday, June 20, 2016 12:37 PM
> To: Commons Developers List
> Cc: findbugs-discuss@cs.umd.edu; findbugs-core@lists.sourceforge.net
> Subject: [VOTE] Release Apache Commons BCEL 6.0 based on RC6
>
> Hi,
>
> after some build related problems with RC5, I'd like to call a vote to
release
> Apache Commons BCEL 6.0 based on RC6. The only changes compared to
> RC5 is a fix in the source assembly: It now includes all files necessary
to run a
> clean build.
>
> BCEL 6.0 RC6 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/bcel (rev 14065)
>
> The tag is here:
>
> https://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_R
> C6
>  (rev 1749388)
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-
> 1179/org/apache/bcel/bcel/6.0/
>
> These are the Maven artifacts and their hashes:
>
> bcel-6.0-javadoc.jar
> (SHA1: 89cf95656f0f8a93e77100c8d5811f7cd9af866b)
> bcel-6.0-sources.jar
> (SHA1: 162f96530e8935e8a71a9e6d5497026aa3bdc945)
> bcel-6.0-test-sources.jar
> (SHA1: 2b07be3a0a4560c9766d3261cd012cf636fe965a)
> bcel-6.0-tests.jar
> (SHA1: 9e825da46e0cd66f87ccd907a43c4e2ebd15b8d6)
> bcel-6.0.jar
> (SHA1: 09d0a4c32ba6c3c22f0680f89ceeaf3e677ac659)
> bcel-6.0.pom
> (SHA1: a5d48ac34909f3a0ac788d37835075be5c2bb9d7)
>
> I have tested this with Java 7 and 8 using Maven 3.3.9 on Mac OS 10.11.5.
>
> Details of changes since 5.2 are in the release notes:
>   https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/changes-
> report.html
>
> Site:
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/
> (note some *relative* links are broken and the 6.0 directories are not yet
> created - these will be OK once the site is deployed)
>
> Clirr Report (compared to 5.2):
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/clirr-report.html
>
> Note that Clirr reports several errors. These have been discussed on the
ML
> already and I uploaded the site a while ago giving everybody the
opportunity
> to raise objections against these changes. These changes are also
explicitly
> noted in the Release notes.
>
> Furthermore java.io.Serializable has been dropped from all BCEL classes.
An
> extended Clirr report including this change can be reviewed here:
>
> http://home.apache.org/~britter/commons/bcel/6.0-RC6/bcel5-bcel6-clirr-
> report.html
>
> We don't consider this to be a problem because we don't see a reason for
> users to serialize BCEL classes.
>
> RAT Report:
>     http://home.apache.org/~britter/commons/bcel/6.0-RC6/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now, i.e. sometime after
> 22:00 CEST 23-June 2016
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> We're almost there... :-)
> Thanks!
> Benedikt


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org