[GitHub] [solr] epugh commented on a diff in pull request #1371: SOLR-15928 Dim add collection buttons in Admin UI when no permission

["epugh (via GitHub)" <gi...@apache.org>]

epugh commented on code in PR #1371:
URL: https://github.com/apache/solr/pull/1371#discussion_r1111012558


##########
solr/webapp/web/partials/collections.html:
##########
@@ -84,7 +84,9 @@
         </p>
 
         <p class="clearfix buttons">
-          <button type="submit" class="submit" ng-disabled="!isPermitted(permissions.COLL_EDIT_PERM)" ng-click="addCollection()"><span>Add Collection</span></button>
+          <button type="submit" ng-class="{submit,disabled:!canEditColl}" ng-disabled="!canEditColl" ng-click="addCollection()">

Review Comment:
   the `{ }` syntax is new to me (I think)...   I like how this looks...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org