You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/04/29 15:40:11 UTC

[GitHub] [skywalking] wu-sheng opened a new pull request #4735: Optimize L1 and L2 aggregation.

wu-sheng opened a new pull request #4735:
URL: https://github.com/apache/skywalking/pull/4735


   - L1 Aggregation. Use **MergableBufferedData** to replace **ReadWriteSafeCache**. This could avoid the lock for every time aggregation of L1.
   - L2 Aggregation. Support **batch mode** in the **MergableBufferedData**, also reduce the lock and lock race for the aggregation of L2.
   - Remove the ** endOfBatch** from the ** StreamData**. With the batch mode supported in the workers, we don't need that. We take advantage of DataCarrier batch consuming feature.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov-io commented on pull request #4735: Optimize L1 and L2 aggregation.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #4735:
URL: https://github.com/apache/skywalking/pull/4735#issuecomment-621299529


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=h1) Report
   > Merging [#4735](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d97af96c8560c0c7615a32de6fb1f9df03c17006&el=desc) will **decrease** coverage by `50.83%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4735/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #4735       +/-   ##
   ============================================
   - Coverage     50.83%   0.00%   -50.84%     
   ============================================
     Files          1287     146     -1141     
     Lines         28125    3650    -24475     
     Branches       3068     439     -2629     
   ============================================
   - Hits          14297       0    -14297     
   + Misses        13181    3650     -9531     
   + Partials        647       0      -647     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [1258 more](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=footer). Last update [d97af96...771871c](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov-io edited a comment on pull request #4735: Optimize L1 and L2 aggregation.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4735:
URL: https://github.com/apache/skywalking/pull/4735#issuecomment-621299529






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] dmsolr commented on a change in pull request #4735: Optimize L1 and L2 aggregation.

Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #4735:
URL: https://github.com/apache/skywalking/pull/4735#discussion_r417749518



##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/data/ReadWriteSafeCache.java
##########
@@ -59,6 +64,20 @@ public void write(T data) {
         }
     }
 
+    /**
+     * Write the collection of data into the {@link #writeBufferPointer} buffer.
+     *
+     * @param data to enqueue.
+     */
+    public void write(List<T> data) {

Review comment:
       Is it ambiguous of method name? Perhaps `writeTo` is better.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov-io edited a comment on pull request #4735: Optimize L1 and L2 aggregation.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4735:
URL: https://github.com/apache/skywalking/pull/4735#issuecomment-621299529


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=h1) Report
   > Merging [#4735](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d97af96c8560c0c7615a32de6fb1f9df03c17006&el=desc) will **decrease** coverage by `21.56%`.
   > The diff coverage is `58.82%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4735/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #4735       +/-   ##
   =============================================
   - Coverage     50.83%   29.26%   -21.57%     
   + Complexity     2653     1540     -1113     
   =============================================
     Files          1287      694      -593     
     Lines         28125    17298    -10827     
     Branches       3068     1672     -1396     
   =============================================
   - Hits          14297     5063     -9234     
   + Misses        13181    11868     -1313     
   + Partials        647      367      -280     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...server/core/analysis/worker/PersistenceWorker.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1BlcnNpc3RlbmNlV29ya2VyLmphdmE=) | `100.00% <ø> (+18.18%)` | `4.00 <0.00> (ø)` | |
   | [...alking/oap/server/core/remote/data/StreamData.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2RhdGEvU3RyZWFtRGF0YS5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (-3.00)` | |
   | [...ng/oap/server/core/analysis/worker/TopNWorker.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5Xb3JrZXIuamF2YQ==) | `43.75% <25.00%> (+1.32%)` | `4.00 <1.00> (ø)` | |
   | [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `71.69% <25.00%> (+3.27%)` | `7.00 <6.00> (ø)` | |
   | [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <83.33%> (-1.22%)` | `6.00 <3.00> (ø)` | |
   | [.../server/core/analysis/data/ReadWriteSafeCache.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9SZWFkV3JpdGVTYWZlQ2FjaGUuamF2YQ==) | `78.94% <100.00%> (-9.29%)` | `3.00 <1.00> (ø)` | |
   | [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `84.37% <100.00%> (+1.85%)` | `24.00 <0.00> (-1.00)` | :arrow_up: |
   | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | ... and [981 more](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=footer). Last update [d97af96...771871c](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] dmsolr commented on a change in pull request #4735: Optimize L1 and L2 aggregation.

Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #4735:
URL: https://github.com/apache/skywalking/pull/4735#discussion_r417749518



##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/data/ReadWriteSafeCache.java
##########
@@ -59,6 +64,20 @@ public void write(T data) {
         }
     }
 
+    /**
+     * Write the collection of data into the {@link #writeBufferPointer} buffer.
+     *
+     * @param data to enqueue.
+     */
+    public void write(List<T> data) {

Review comment:
       Is it ambiguous of method name? Perhaps `writeTo` is better.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov-io edited a comment on pull request #4735: Optimize L1 and L2 aggregation.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4735:
URL: https://github.com/apache/skywalking/pull/4735#issuecomment-621299529






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov-io edited a comment on pull request #4735: Optimize L1 and L2 aggregation.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4735:
URL: https://github.com/apache/skywalking/pull/4735#issuecomment-621299529


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=h1) Report
   > Merging [#4735](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d97af96c8560c0c7615a32de6fb1f9df03c17006&el=desc) will **decrease** coverage by `17.83%`.
   > The diff coverage is `58.82%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4735/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #4735       +/-   ##
   =============================================
   - Coverage     50.83%   32.99%   -17.84%     
   + Complexity     2653     1701      -952     
   =============================================
     Files          1287      700      -587     
     Lines         28125    17397    -10728     
     Branches       3068     1679     -1389     
   =============================================
   - Hits          14297     5740     -8557     
   + Misses        13181    11247     -1934     
   + Partials        647      410      -237     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...server/core/analysis/worker/PersistenceWorker.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1BlcnNpc3RlbmNlV29ya2VyLmphdmE=) | `100.00% <ø> (+18.18%)` | `4.00 <0.00> (ø)` | |
   | [...alking/oap/server/core/remote/data/StreamData.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2RhdGEvU3RyZWFtRGF0YS5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (-3.00)` | |
   | [...ng/oap/server/core/analysis/worker/TopNWorker.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5Xb3JrZXIuamF2YQ==) | `43.75% <25.00%> (+1.32%)` | `4.00 <1.00> (ø)` | |
   | [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `71.69% <25.00%> (+3.27%)` | `7.00 <6.00> (ø)` | |
   | [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <83.33%> (-1.22%)` | `6.00 <3.00> (ø)` | |
   | [.../server/core/analysis/data/ReadWriteSafeCache.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9SZWFkV3JpdGVTYWZlQ2FjaGUuamF2YQ==) | `78.94% <100.00%> (-9.29%)` | `3.00 <1.00> (ø)` | |
   | [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `84.37% <100.00%> (+1.85%)` | `24.00 <0.00> (-1.00)` | :arrow_up: |
   | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | ... and [964 more](https://codecov.io/gh/apache/skywalking/pull/4735/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=footer). Last update [d97af96...771871c](https://codecov.io/gh/apache/skywalking/pull/4735?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org