You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@storm.apache.org by "Jungtaek Lim (JIRA)" <ji...@apache.org> on 2018/01/25 06:11:00 UTC

[jira] [Created] (STORM-2912) Tick tuple is being shared without thread-safety and incur side-effect to break metrics

Jungtaek Lim created STORM-2912:
-----------------------------------

             Summary: Tick tuple is being shared without thread-safety and incur side-effect to break metrics
                 Key: STORM-2912
                 URL: https://issues.apache.org/jira/browse/STORM-2912
             Project: Apache Storm
          Issue Type: Bug
          Components: storm-client, storm-core
    Affects Versions: 2.0.0, 1.2.0, 1.1.2, 1.0.6
            Reporter: Jungtaek Lim
            Assignee: Jungtaek Lim


In STORM-2786 we have applied small optimization: create tick tuple only once and reuse. The optimization completely makes sense, but when measuring built-in metrics, it utilize tuple's "mutable" fields which is thread-unsafe and opens side-effect.

What I've observed is that delta for tick tuple is gradually increasing for some time-period, and reset to 0, which messes up latencies. It also messes up executed as well because it is always considered as selected tuple (hence recorded to 20x for tick tuple), but unless interval of tick tuple is super small, the effect is much smaller then latency.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)