[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #12009: fix: Scroll for big charts

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #12009:
URL: https://github.com/apache/incubator-superset/pull/12009#discussion_r542040644



##########
File path: superset-frontend/src/chart/Chart.jsx
##########
@@ -212,6 +215,7 @@ class Chart extends React.PureComponent {
           <div
             className={`slice_container ${isFaded ? ' faded' : ''}`}
             data-test="slice-container"
+            style={{ width, overflow: 'scroll' }}

Review comment:
       many visualization plugins may end up overflowing by a few pixels for whatever reason and we may not want to show the scrollbar.

##########
File path: superset-frontend/src/chart/Chart.jsx
##########
@@ -87,6 +87,9 @@ const Styles = styled.div`
     opacity: 0.75;
     font-size: ${({ theme }) => theme.typography.sizes.s}px;
   }
+  svg {

Review comment:
       Yes we can't assume that there will be SVG or that it should overflow one way or another.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org