You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2018/01/22 16:29:48 UTC
[GitHub] zeppelin pull request #2739: [ZEPPELIN-3183] Add date format support for lin...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2739
[ZEPPELIN-3183] Add date format support for line chart as x-axis
### What is this PR for?
Add date format support for line chart as x-axis
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* [ZEPPELIN-3183](https://issues.apache.org/jira/browse/ZEPPELIN-3183)
### Screenshots (if appropriate)
Before
![before](https://user-images.githubusercontent.com/674497/35231655-5cb7b5f6-ffbf-11e7-8dfa-541985946fcb.gif)
After
![after](https://user-images.githubusercontent.com/674497/35231653-5c67d23e-ffbf-11e7-8ee8-33dedf137f73.gif)
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3183
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2739.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2739
----
commit a0f77777155d0e9d319b708bb0f05a22a8bdf166
Author: Prabhjyot Singh <pr...@...>
Date: 2018-01-22T16:27:00Z
ZEPPELIN-3183: Add date format support for line chart
----
---
[GitHub] zeppelin issue #2739: [ZEPPELIN-3183] Add date format support for line chart...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2739
Thanks for the review will merge this if no more discussion.
---
[GitHub] zeppelin issue #2739: [ZEPPELIN-3183] Add date format support for line chart...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2739
I think the number what you see after +{number} is the time zone. Eg:
```
Default which is coming from query -> 2018-01-22T14:57:43+0000
When enabled Date -> Mon Jan 22 2018 20:27:43 GMT+0530 (IST)
```
---
[GitHub] zeppelin pull request #2739: [ZEPPELIN-3183] Add date format support for lin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2739
---
[GitHub] zeppelin issue #2739: [ZEPPELIN-3183] Add date format support for line chart...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2739
LGTM,one minor concern: is the millisecond displayed by default ? IMO, second should be sufficient for most of cases.
---