You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by rf...@apache.org on 2012/11/22 20:57:26 UTC

svn commit: r1412650 - in /maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker: AbstractInvokerMojo.java InvokerProperties.java SystemPropertyPrinter.java

Author: rfscholte
Date: Thu Nov 22 19:57:25 2012
New Revision: 1412650

URL: http://svn.apache.org/viewvc?rev=1412650&view=rev
Log:
checkstyle fixes

Modified:
    maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java
    maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/InvokerProperties.java
    maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/SystemPropertyPrinter.java

Modified: maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java?rev=1412650&r1=1412649&r2=1412650&view=diff
==============================================================================
--- maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java (original)
+++ maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java Thu Nov 22 19:57:25 2012
@@ -614,7 +614,7 @@ public abstract class AbstractInvokerMoj
     private String actualJreVersion;
     
     
-    private final void setActualJreVersion( String actualJreVersion )
+    private void setActualJreVersion( String actualJreVersion )
     {
         this.actualJreVersion = actualJreVersion;
     }
@@ -1172,7 +1172,7 @@ public abstract class AbstractInvokerMoj
                 getLog().info( "use parallelThreads " + parallelThreads );
 
                 ExecutorService executorService = Executors.newFixedThreadPool( parallelThreads );
-                for ( final BuildJob project : buildJobs )
+                for ( final BuildJob job : buildJobs )
                 {
                     executorService.execute( new Runnable()
                     {
@@ -1181,7 +1181,7 @@ public abstract class AbstractInvokerMoj
                         {
                             try
                             {
-                                runBuild( projectsDir, project, finalSettingsFile );
+                                runBuild( projectsDir, job, finalSettingsFile );
                             }
                             catch ( MojoExecutionException e )
                             {
@@ -1205,9 +1205,9 @@ public abstract class AbstractInvokerMoj
             }
             else
             {
-                for ( BuildJob project : buildJobs )
+                for ( BuildJob job : buildJobs )
                 {
-                    runBuild( projectsDir, project, finalSettingsFile );
+                    runBuild( projectsDir, job, finalSettingsFile );
                 }
             }
         }
@@ -1231,15 +1231,15 @@ public abstract class AbstractInvokerMoj
 
         // MINVOKER-133: reset sourceLevelSet
         resetSourceLevelSet( recessiveSettings );
-        for( org.apache.maven.settings.Mirror mirror : recessiveSettings.getMirrors() )
+        for ( org.apache.maven.settings.Mirror mirror : recessiveSettings.getMirrors() )
         {
             resetSourceLevelSet( mirror );
         }
-        for( org.apache.maven.settings.Server server : recessiveSettings.getServers())
+        for ( org.apache.maven.settings.Server server : recessiveSettings.getServers() )
         {
             resetSourceLevelSet( server );
         }
-        for( org.apache.maven.settings.Proxy proxy : recessiveSettings.getProxies() )
+        for ( org.apache.maven.settings.Proxy proxy : recessiveSettings.getProxies() )
         {
             resetSourceLevelSet( proxy );
         }
@@ -1270,7 +1270,7 @@ public abstract class AbstractInvokerMoj
         pluginArtifact.getFile();
         
         Commandline commandLine = new Commandline();
-        commandLine.setExecutable( new File( javaHome, "bin/java").getAbsolutePath() );
+        commandLine.setExecutable( new File( javaHome, "bin/java" ).getAbsolutePath() );
         commandLine.createArg().setValue( "-cp" );
         commandLine.createArg().setFile( pluginArtifact.getFile() );
         commandLine.createArg().setValue( SystemPropertyPrinter.class.getName() );
@@ -1396,7 +1396,7 @@ public abstract class AbstractInvokerMoj
                 }
                 if ( ( selection & SELECTOR_JREVERSION ) != 0 )
                 {
-                    if( message.length() > 0 )
+                    if ( message.length() > 0 )
                     {
                         message.append( ", " );
                     }
@@ -1404,7 +1404,7 @@ public abstract class AbstractInvokerMoj
                 }
                 if ( ( selection & SELECTOR_OSFAMILY ) != 0 )
                 {
-                    if( message.length() > 0 )
+                    if ( message.length() > 0 )
                     {
                         message.append( ", " );
                     }
@@ -1627,7 +1627,7 @@ public abstract class AbstractInvokerMoj
             
             if ( environmentVariables != null )
             {
-                for( Map.Entry<String, String> variable : environmentVariables.entrySet() )
+                for ( Map.Entry<String, String> variable : environmentVariables.entrySet() )
                 {
                     request.addShellEnvironment( variable.getKey(), variable.getValue() );
                 }

Modified: maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/InvokerProperties.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/InvokerProperties.java?rev=1412650&r1=1412649&r2=1412650&view=diff
==============================================================================
--- maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/InvokerProperties.java (original)
+++ maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/InvokerProperties.java Thu Nov 22 19:57:25 2012
@@ -241,7 +241,7 @@ class InvokerProperties
         }
         
         String debug = get( DEBUG, index );
-        if( debug != null )
+        if ( debug != null )
         {
             request.setDebug( Boolean.valueOf( debug ).booleanValue() );    
         }

Modified: maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/SystemPropertyPrinter.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/SystemPropertyPrinter.java?rev=1412650&r1=1412649&r2=1412650&view=diff
==============================================================================
--- maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/SystemPropertyPrinter.java (original)
+++ maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/SystemPropertyPrinter.java Thu Nov 22 19:57:25 2012
@@ -30,7 +30,7 @@ package org.apache.maven.plugin.invoker;
 public class SystemPropertyPrinter
 {
     /**
-     * @param args
+     * @param args system properties to print
      */
     public static void main( String[] args )
     {