You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/12/14 14:46:44 UTC

[GitHub] [hbase] Apache9 commented on pull request #3936: HBASE-26555 Fix findbugs/spotbugs findings

Apache9 commented on pull request #3936:
URL: https://github.com/apache/hbase/pull/3936#issuecomment-993615338


   > Each module has its own commit in the PR branch @Apache9 . I think that is the best we can do as far as keeping each review item small.
   > 
   > In other words
   > 
   > I am aware the patch is big over all.
   > 
   > So there are multiple commits on this PR. Find them here: https://github.com/apache/hbase/pull/3936/commits
   > 
   > Each commit has the changes just for one maven module.
   
   We could just use multiple PRs to get them in? A problem for a big PR is that, we could have a lot of small nits every time when reviewing, on different part of the big PR, then we can not land the whole PR, which will lead to a very long review time and easy to introduce conflicts with other commits...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org