You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/10/19 21:44:59 UTC
[jira] Created: (CASSANDRA-498) Replace EndPoint class with
InetAddress
Replace EndPoint class with InetAddress
---------------------------------------
Key: CASSANDRA-498
URL: https://issues.apache.org/jira/browse/CASSANDRA-498
Project: Cassandra
Issue Type: Improvement
Components: Core
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Fix For: 0.5
EndPoint is problematic because there are two for each node: one for the TCP port (used for all data-related traffic), and one for UDP (for gossip). Often you will have a collection of one type of EndPoint, and want to look it up by the other type; this gives rise to abominations such as retrofitPorts and hard-to-find bugs.
Replacing EndPoint with the standard and port-less InetAddress fixes these problems. (We push the actual tcp/udp ports into TcpConnection / UdpConnection, where they belong.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-498) Replace EndPoint class with
InetAddress
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768356#action_12768356 ]
Brandon Williams commented on CASSANDRA-498:
--------------------------------------------
+1, tests pass and this also allows me to specify a hostname as a seed.
> Replace EndPoint class with InetAddress
> ---------------------------------------
>
> Key: CASSANDRA-498
> URL: https://issues.apache.org/jira/browse/CASSANDRA-498
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-498-r-m-unused-listening-distinction-in-Tc.txt, 0002-r-m-uses-of-EndPoint-port-constructor-rename-EndPoin.txt, 0003-convert-EndPoint-to-InetAddress-removes-MembershipCle.txt
>
>
> EndPoint is problematic because there are two for each node: one for the TCP port (used for all data-related traffic), and one for UDP (for gossip). Often you will have a collection of one type of EndPoint, and want to look it up by the other type; this gives rise to abominations such as retrofitPorts and hard-to-find bugs.
> Replacing EndPoint with the standard and port-less InetAddress fixes these problems. (We push the actual tcp/udp ports into TcpConnection / UdpConnection, where they belong.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-498) Replace EndPoint class with
InetAddress
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768663#action_12768663 ]
Hudson commented on CASSANDRA-498:
----------------------------------
Integrated in Cassandra #235 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/235/])
convert EndPoint to InetAddress (removes MembershipCleaner, the code to drop a node from the cluster entirely. we're probably going to want to resurrect that at some point)
patch by jbellis; reviewed by Brandon Williams for
r/m uses of EndPoint(port) constructor; rename EndPoint methods to make porting easier; r/m gratuitous uses of getHost
patch by jbellis; reviewed by Brandon Williams for
r/m unused "listening" distinction in TcpConnection
patch by jbellis; reviewed by Brandon Williams for
> Replace EndPoint class with InetAddress
> ---------------------------------------
>
> Key: CASSANDRA-498
> URL: https://issues.apache.org/jira/browse/CASSANDRA-498
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-498-r-m-unused-listening-distinction-in-Tc.txt, 0002-r-m-uses-of-EndPoint-port-constructor-rename-EndPoin.txt, 0003-convert-EndPoint-to-InetAddress-removes-MembershipCle.txt
>
>
> EndPoint is problematic because there are two for each node: one for the TCP port (used for all data-related traffic), and one for UDP (for gossip). Often you will have a collection of one type of EndPoint, and want to look it up by the other type; this gives rise to abominations such as retrofitPorts and hard-to-find bugs.
> Replacing EndPoint with the standard and port-less InetAddress fixes these problems. (We push the actual tcp/udp ports into TcpConnection / UdpConnection, where they belong.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-498) Replace EndPoint class with
InetAddress
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-498.
--------------------------------------
Resolution: Fixed
committed
> Replace EndPoint class with InetAddress
> ---------------------------------------
>
> Key: CASSANDRA-498
> URL: https://issues.apache.org/jira/browse/CASSANDRA-498
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-498-r-m-unused-listening-distinction-in-Tc.txt, 0002-r-m-uses-of-EndPoint-port-constructor-rename-EndPoin.txt, 0003-convert-EndPoint-to-InetAddress-removes-MembershipCle.txt
>
>
> EndPoint is problematic because there are two for each node: one for the TCP port (used for all data-related traffic), and one for UDP (for gossip). Often you will have a collection of one type of EndPoint, and want to look it up by the other type; this gives rise to abominations such as retrofitPorts and hard-to-find bugs.
> Replacing EndPoint with the standard and port-less InetAddress fixes these problems. (We push the actual tcp/udp ports into TcpConnection / UdpConnection, where they belong.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-498) Replace EndPoint class with
InetAddress
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-498:
-------------------------------------
Attachment: 0003-convert-EndPoint-to-InetAddress-removes-MembershipCle.txt
0002-r-m-uses-of-EndPoint-port-constructor-rename-EndPoin.txt
0001-CASSANDRA-498-r-m-unused-listening-distinction-in-Tc.txt
> Replace EndPoint class with InetAddress
> ---------------------------------------
>
> Key: CASSANDRA-498
> URL: https://issues.apache.org/jira/browse/CASSANDRA-498
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-498-r-m-unused-listening-distinction-in-Tc.txt, 0002-r-m-uses-of-EndPoint-port-constructor-rename-EndPoin.txt, 0003-convert-EndPoint-to-InetAddress-removes-MembershipCle.txt
>
>
> EndPoint is problematic because there are two for each node: one for the TCP port (used for all data-related traffic), and one for UDP (for gossip). Often you will have a collection of one type of EndPoint, and want to look it up by the other type; this gives rise to abominations such as retrofitPorts and hard-to-find bugs.
> Replacing EndPoint with the standard and port-less InetAddress fixes these problems. (We push the actual tcp/udp ports into TcpConnection / UdpConnection, where they belong.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.