[jira] [Commented] (ZOOKEEPER-1389) it would be nice if start-foreground used exec $JAVA in order to get rid of the intermediate shell process

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203946#comment-13203946 ] 

Hadoop QA commented on ZOOKEEPER-1389:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12513853/ZOOKEEPER-1389.patch.txt
  against trunk revision 1240959.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/954//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/954//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/954//console

This message is automatically generated.
                
> it would be nice if start-foreground used exec $JAVA in order to get rid of the intermediate shell process
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1389
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1389
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: scripts, server
>    Affects Versions: 3.4.2
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>         Attachments: ZOOKEEPER-1389.patch.txt
>
>
> A log of daemon management tools expect a process itself to be running as a child instead of a grand-child. It would be nice if we had an option for that in zkServer.sh

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira