You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "Pochatkin (via GitHub)" <gi...@apache.org> on 2023/04/21 13:45:22 UTC
[GitHub] [ignite-3] Pochatkin opened a new pull request, #1970: IGNITE-19107: Remove LATEST semantic from deployment API
Pochatkin opened a new pull request, #1970:
URL: https://github.com/apache/ignite-3/pull/1970
https://issues.apache.org/jira/browse/IGNITE-19107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #1970: IGNITE-19107: Remove LATEST semantic from deployment API
Posted by "PakhomovAlexander (via GitHub)" <gi...@apache.org>.
PakhomovAlexander commented on code in PR #1970:
URL: https://github.com/apache/ignite-3/pull/1970#discussion_r1176768476
##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/Main.java:
##########
@@ -56,7 +56,7 @@ public static void main(String[] args) {
try (MicronautFactory micronautFactory = new MicronautFactory(builder.start())) {
AnsiConsole.systemInstall();
initReplExecutor(micronautFactory);
- if (args.length != 0 || !isatty()) { // do not enter REPL if input or output is redirected
+ if (args.length != 0 /*|| !isatty()*/) { // do not enter REPL if input or output is redirected
Review Comment:
Could you please explain why does this change make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] Pochatkin commented on a diff in pull request #1970: IGNITE-19107: Remove LATEST semantic from deployment API
Posted by "Pochatkin (via GitHub)" <gi...@apache.org>.
Pochatkin commented on code in PR #1970:
URL: https://github.com/apache/ignite-3/pull/1970#discussion_r1178843559
##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/Main.java:
##########
@@ -56,7 +56,7 @@ public static void main(String[] args) {
try (MicronautFactory micronautFactory = new MicronautFactory(builder.start())) {
AnsiConsole.systemInstall();
initReplExecutor(micronautFactory);
- if (args.length != 0 || !isatty()) { // do not enter REPL if input or output is redirected
+ if (args.length != 0 /*|| !isatty()*/) { // do not enter REPL if input or output is redirected
Review Comment:
Miss comment, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] PakhomovAlexander merged pull request #1970: IGNITE-19107: Remove LATEST semantic from deployment API
Posted by "PakhomovAlexander (via GitHub)" <gi...@apache.org>.
PakhomovAlexander merged PR #1970:
URL: https://github.com/apache/ignite-3/pull/1970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org