[jira] [Commented] (STORM-1270) port backtype.storm.daemon.drpc to java

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174282#comment-15174282 ] 

ASF GitHub Bot commented on STORM-1270:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1156#discussion_r54622279
  
    --- Diff: storm-core/src/jvm/org/apache/storm/LocalDRPC.java ---
    @@ -0,0 +1,80 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.storm;
    +
    +import org.apache.log4j.Logger;
    +import org.apache.storm.daemon.DrpcServer;
    +import org.apache.storm.generated.AuthorizationException;
    +import org.apache.storm.generated.DRPCExecutionException;
    +import org.apache.storm.generated.DRPCRequest;
    +import org.apache.storm.utils.ConfigUtils;
    +import org.apache.storm.utils.ServiceRegistry;
    +import org.apache.storm.utils.Utils;
    +import org.apache.thrift.TException;
    +
    +import java.util.Map;
    +
    +public class LocalDRPC implements ILocalDRPC {
    +    private static final Logger LOG = Logger.getLogger(LocalDRPC.class);
    +
    +    private DrpcServer handler = new DrpcServer();
    +    private Thread thread;
    --- End diff --
    
    This is never used and should be removed.


> port backtype.storm.daemon.drpc to java
> ---------------------------------------
>
>                 Key: STORM-1270
>                 URL: https://issues.apache.org/jira/browse/STORM-1270
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: John Fang
>              Labels: java-migration, jstorm-merger
>
> DRPC server with HTTP and thrift support
> https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/drpc/Drpc.java
> (But missing HTTP support)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)