You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@karaf.apache.org by James Carman <ja...@carmanconsulting.com> on 2016/07/29 17:53:43 UTC
featuresBoot order not honored...
It looks like this commit:
https://github.com/apache/karaf/commit/5788fa8958e3bbcf8119d7b3587d5ce7e943894f
broke the featuresBoot ordering. We used to use a LinkedHashSet to
maintain the order, but somehow the "staged" stuff was implemented with a
regular ole HashSet. Shouldn't the order of the featuresBoot property be
honored? It's supposed to be an ordered list of the features to install,
right? I can provide a patch, but I wanted to ask folks if my assumption
that the featuresBoot is supposed to be treated as a list and not a set
holds water.
Thanks,
James
Re: featuresBoot order not honored...
Posted by James Carman <ja...@carmanconsulting.com>.
https://issues.apache.org/jira/browse/KARAF-4642
On Fri, Jul 29, 2016 at 9:02 PM Matt Sicker <bo...@gmail.com> wrote:
> Definitely would like ordering to be honored considering third party
> libraries require this sometimes.
>
> On 29 July 2016 at 14:11, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
>
> > Hi James,
> >
> > thanks for the update.
> >
> > I gonna take a look on your PR.
> >
> > Regards
> > JB
> >
> >
> > On 07/29/2016 07:53 PM, James Carman wrote:
> >
> >> It looks like this commit:
> >>
> >>
> >>
> https://github.com/apache/karaf/commit/5788fa8958e3bbcf8119d7b3587d5ce7e943894f
> >>
> >> broke the featuresBoot ordering. We used to use a LinkedHashSet to
> >> maintain the order, but somehow the "staged" stuff was implemented with
> a
> >> regular ole HashSet. Shouldn't the order of the featuresBoot property
> be
> >> honored? It's supposed to be an ordered list of the features to
> install,
> >> right? I can provide a patch, but I wanted to ask folks if my
> assumption
> >> that the featuresBoot is supposed to be treated as a list and not a set
> >> holds water.
> >>
> >> Thanks,
> >>
> >> James
> >>
> >>
> > --
> > Jean-Baptiste Onofré
> > jbonofre@apache.org
> > http://blog.nanthrax.net
> > Talend - http://www.talend.com
> >
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
Re: featuresBoot order not honored...
Posted by Matt Sicker <bo...@gmail.com>.
Definitely would like ordering to be honored considering third party
libraries require this sometimes.
On 29 July 2016 at 14:11, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> Hi James,
>
> thanks for the update.
>
> I gonna take a look on your PR.
>
> Regards
> JB
>
>
> On 07/29/2016 07:53 PM, James Carman wrote:
>
>> It looks like this commit:
>>
>>
>> https://github.com/apache/karaf/commit/5788fa8958e3bbcf8119d7b3587d5ce7e943894f
>>
>> broke the featuresBoot ordering. We used to use a LinkedHashSet to
>> maintain the order, but somehow the "staged" stuff was implemented with a
>> regular ole HashSet. Shouldn't the order of the featuresBoot property be
>> honored? It's supposed to be an ordered list of the features to install,
>> right? I can provide a patch, but I wanted to ask folks if my assumption
>> that the featuresBoot is supposed to be treated as a list and not a set
>> holds water.
>>
>> Thanks,
>>
>> James
>>
>>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>
--
Matt Sicker <bo...@gmail.com>
Re: featuresBoot order not honored...
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi James,
thanks for the update.
I gonna take a look on your PR.
Regards
JB
On 07/29/2016 07:53 PM, James Carman wrote:
> It looks like this commit:
>
> https://github.com/apache/karaf/commit/5788fa8958e3bbcf8119d7b3587d5ce7e943894f
>
> broke the featuresBoot ordering. We used to use a LinkedHashSet to
> maintain the order, but somehow the "staged" stuff was implemented with a
> regular ole HashSet. Shouldn't the order of the featuresBoot property be
> honored? It's supposed to be an ordered list of the features to install,
> right? I can provide a patch, but I wanted to ask folks if my assumption
> that the featuresBoot is supposed to be treated as a list and not a set
> holds water.
>
> Thanks,
>
> James
>
--
Jean-Baptiste Onofr�
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: featuresBoot order not honored...
Posted by James Carman <ja...@carmanconsulting.com>.
I should say I'm using version 3.0.4.
On Fri, Jul 29, 2016 at 1:53 PM James Carman <ja...@carmanconsulting.com>
wrote:
> It looks like this commit:
>
>
> https://github.com/apache/karaf/commit/5788fa8958e3bbcf8119d7b3587d5ce7e943894f
>
> broke the featuresBoot ordering. We used to use a LinkedHashSet to
> maintain the order, but somehow the "staged" stuff was implemented with a
> regular ole HashSet. Shouldn't the order of the featuresBoot property be
> honored? It's supposed to be an ordered list of the features to install,
> right? I can provide a patch, but I wanted to ask folks if my assumption
> that the featuresBoot is supposed to be treated as a list and not a set
> holds water.
>
> Thanks,
>
> James
>