You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opennlp.apache.org by jo...@apache.org on 2016/12/26 13:34:15 UTC
[21/50] [abbrv] opennlp git commit: Use StringBuilder.append and not
string cat
Use StringBuilder.append and not string cat
The argument to StringBuilder.append should not be
concatenated. Instead StringBuilder.append can be called
more often.
See issue OPENNLP-871
Project: http://git-wip-us.apache.org/repos/asf/opennlp/repo
Commit: http://git-wip-us.apache.org/repos/asf/opennlp/commit/7ef7235f
Tree: http://git-wip-us.apache.org/repos/asf/opennlp/tree/7ef7235f
Diff: http://git-wip-us.apache.org/repos/asf/opennlp/diff/7ef7235f
Branch: refs/heads/889
Commit: 7ef7235f04f9e26cf41155a92ab2a2632a7ba7e6
Parents: b854d31
Author: J�rn Kottmann <jo...@apache.org>
Authored: Wed Nov 2 19:52:08 2016 +0100
Committer: J�rn Kottmann <jo...@apache.org>
Committed: Mon Dec 19 23:37:33 2016 +0100
----------------------------------------------------------------------
.../java/opennlp/tools/cmdline/DetailedFMeasureListener.java | 6 +++---
.../main/java/opennlp/tools/cmdline/GenerateManualTool.java | 8 ++++----
.../tools/formats/ontonotes/OntoNotesParseSampleStream.java | 2 +-
3 files changed, 8 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/opennlp/blob/7ef7235f/opennlp-tools/src/main/java/opennlp/tools/cmdline/DetailedFMeasureListener.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/DetailedFMeasureListener.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/DetailedFMeasureListener.java
index f4c38cb..ccf6884 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/cmdline/DetailedFMeasureListener.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/cmdline/DetailedFMeasureListener.java
@@ -120,9 +120,9 @@ public abstract class DetailedFMeasureListener<T> implements
StringBuilder ret = new StringBuilder();
int tp = generalStats.getTruePositives();
int found = generalStats.getFalsePositives() + tp;
- ret.append("Evaluated " + samples + " samples with "
- + generalStats.getTarget() + " entities; found: " + found
- + " entities; correct: " + tp + ".\n");
+ ret.append("Evaluated ").append(samples).append(" samples with ")
+ .append(generalStats.getTarget()).append(" entities; found: ")
+ .append(found).append(" entities; correct: ").append(tp).append(".\n");
ret.append(String.format(locale, FORMAT, "TOTAL",
zeroOrPositive(generalStats.getPrecisionScore() * 100),
http://git-wip-us.apache.org/repos/asf/opennlp/blob/7ef7235f/opennlp-tools/src/main/java/opennlp/tools/cmdline/GenerateManualTool.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/GenerateManualTool.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/GenerateManualTool.java
index b9dcc2d..ed58dde 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/cmdline/GenerateManualTool.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/cmdline/GenerateManualTool.java
@@ -160,8 +160,8 @@ public class GenerateManualTool {
for (Argument argument : arguments) {
sb.append("<row>\n");
if (i == 0) {
- sb.append("<entry morerows='" + (arguments.size() - 1)
- + "' valign='middle'>").append(format).append("</entry>\n");
+ sb.append("<entry morerows='").append(arguments.size() - 1)
+ .append("' valign='middle'>").append(format).append("</entry>\n");
}
sb.append("<entry>").append(argument.getArgument())
.append("</entry>\n");
@@ -229,8 +229,8 @@ public class GenerateManualTool {
}
private static void appendCode(String help, StringBuilder sb) {
- sb.append("<screen>\n" + "<![CDATA[\n" + splitLongLines(help) + "\n"
- + "]]>\n" + "</screen> \n");
+ sb.append("<screen>\n" + "<![CDATA[\n").append(splitLongLines(help))
+ .append("\n").append("]]>\n").append("</screen> \n");
}
/**
http://git-wip-us.apache.org/repos/asf/opennlp/blob/7ef7235f/opennlp-tools/src/main/java/opennlp/tools/formats/ontonotes/OntoNotesParseSampleStream.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/formats/ontonotes/OntoNotesParseSampleStream.java b/opennlp-tools/src/main/java/opennlp/tools/formats/ontonotes/OntoNotesParseSampleStream.java
index 690196a..1627ca5 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/formats/ontonotes/OntoNotesParseSampleStream.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/formats/ontonotes/OntoNotesParseSampleStream.java
@@ -51,7 +51,7 @@ public class OntoNotesParseSampleStream extends FilterObjectStream<String, Parse
}
}
- parseString.append(parse + " ");
+ parseString.append(parse).append(" ");
}
}
}