You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by nikhilkh <gi...@git.apache.org> on 2015/06/05 19:01:58 UTC
[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-cli/pull/215
CB-9121 Add support for build configuration to be specified using the CLI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-cli buildConfig
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-cli/pull/215.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #215
----
commit 7e88fd4937f1f527a6e6aa1f144a5055491f172c
Author: Nikhil Khandelwal <ni...@microsoft.com>
Date: 2015-06-03T22:21:57Z
CB-9121 Add support for build configuration to be specified using the CLI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/215#discussion_r31853375
--- Diff: doc/build.txt ---
@@ -18,6 +19,9 @@ all/the specified platforms.
--emulator ......................... Deploy to an emulator
--target ........................... Deploy to a specific target
+ --buildConfig....................... Use the specified build configuration
--- End diff --
:+1: ... At the very least, it should have (on line 9) `--buildConfig=CONFIGFILE` or something like that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...
Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/215#discussion_r31844480
--- Diff: src/cli.js ---
@@ -226,7 +227,9 @@ function cli(inputArgs) {
downstreamArgs.push('--' + flag);
}
});
-
+ if (args.buildConfig) {
+ downstreamArgs.push('--buildConfig=' + args.buildConfig);
--- End diff --
ok, never mind. it seems like cordova-lib just passes the --buildConfig args to the underlying platform, which does the bulk of the work : https://github.com/apache/cordova-android/pull/164
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/215#discussion_r31853903
--- Diff: doc/build.txt ---
@@ -18,6 +19,9 @@ all/the specified platforms.
--emulator ......................... Deploy to an emulator
--target ........................... Deploy to a specific target
+ --buildConfig....................... Use the specified build configuration
--- End diff --
Addressed both comments - added an example and fixed the grammar definition on line 9.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...
Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/215#issuecomment-109439886
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...
Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/215#discussion_r31841226
--- Diff: doc/build.txt ---
@@ -18,6 +19,9 @@ all/the specified platforms.
--emulator ......................... Deploy to an emulator
--target ........................... Deploy to a specific target
+ --buildConfig....................... Use the specified build configuration
--- End diff --
It'd be great if you could document an example of how to use this flag in both build.txt and run.txt
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/215
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...
Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/215#discussion_r31843167
--- Diff: src/cli.js ---
@@ -226,7 +227,9 @@ function cli(inputArgs) {
downstreamArgs.push('--' + flag);
}
});
-
+ if (args.buildConfig) {
+ downstreamArgs.push('--buildConfig=' + args.buildConfig);
--- End diff --
don't we need a corresponding PR for cordova-lib ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-cli/pull/215#issuecomment-109445919
:+1: apart from the one small thing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/215#discussion_r31854039
--- Diff: doc/build.txt ---
@@ -18,6 +19,9 @@ all/the specified platforms.
--emulator ......................... Deploy to an emulator
--target ........................... Deploy to a specific target
+ --buildConfig....................... Use the specified build configuration
--- End diff --
:shipit:!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org