You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "wangweiufofly (GitHub)" <gi...@apache.org> on 2018/11/23 03:48:34 UTC
[GitHub] [incubator-dubbo] wangweiufofly opened pull request #2822:
Fix FailbackClusterInvoker one risk of memory leak #2425
1.limit the size of the map,default is 1000. can config by key failcapacity
2.retry period,default is 100.can config by key retries.
3.shutdown the timer when destroyed
The issues:
https://github.com/apache/incubator-dubbo/issues/2425
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on pull request #2822:
Fix FailbackClusterInvoker one risk of memory leak #2425
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
1. DEFAULT_FAIL_RETRY_SIZE maybe changed to DEFAULT_FAILBACK_TIMES
2. 100 is also too large. maybe 3 is enough.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2822: Fix
FailbackClusterInvoker one risk of memory leak #2425
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=h1) Report
> Merging [#2822](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/227a1699ac041b9e99e31ba3dfcff5d2307ee77b?src=pr&el=desc) will **decrease** coverage by `0.09%`.
> The diff coverage is `43.9%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2822 +/- ##
=========================================
- Coverage 63.99% 63.89% -0.1%
=========================================
Files 584 584
Lines 26050 26069 +19
Branches 4562 4567 +5
=========================================
- Hits 16671 16658 -13
- Misses 7200 7227 +27
- Partials 2179 2184 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `88.88% <ø> (ø)` | :arrow_up: |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `58.92% <43.9%> (-27.56%)` | :arrow_down: |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | :arrow_down: |
| [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `75% <0%> (-11.12%)` | :arrow_down: |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `43.42% <0%> (-10.53%)` | :arrow_down: |
| [...in/java/org/apache/dubbo/common/utils/JVMUtil.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvSlZNVXRpbC5qYXZh) | `73.58% <0%> (-7.55%)` | :arrow_down: |
| [...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==) | `85.71% <0%> (-3.58%)` | :arrow_down: |
| [...pache/dubbo/remoting/transport/AbstractServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RTZXJ2ZXIuamF2YQ==) | `44.79% <0%> (-3.13%)` | :arrow_down: |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `68.45% <0%> (-2.69%)` | :arrow_down: |
| [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `63.79% <0%> (-1.73%)` | :arrow_down: |
| ... and [5 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=footer). Last update [227a169...70dff7c](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] wangweiufofly commented on pull request
#2822: Fix FailbackClusterInvoker one risk of memory leak #2425
Posted by "wangweiufofly (GitHub)" <gi...@apache.org>.
Good idea. I've changed it.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2822: Fix
FailbackClusterInvoker one risk of memory leak #2425
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=h1) Report
> Merging [#2822](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/a35f9420fb13d37e7a136e47ea0bfe5a4cf83550?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `70%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2822 +/- ##
==========================================
- Coverage 64.38% 64.35% -0.03%
==========================================
Files 584 584
Lines 26084 26111 +27
Branches 4559 4564 +5
==========================================
+ Hits 16795 16805 +10
- Misses 7111 7122 +11
- Partials 2178 2184 +6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `88.88% <ø> (ø)` | :arrow_up: |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `76.19% <70%> (-10.3%)` | :arrow_down: |
| [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `69.23% <0%> (-12.83%)` | :arrow_down: |
| [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `75% <0%> (-11.12%)` | :arrow_down: |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `43.42% <0%> (-10.53%)` | :arrow_down: |
| [...in/java/org/apache/dubbo/common/utils/JVMUtil.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvSlZNVXRpbC5qYXZh) | `73.58% <0%> (-7.55%)` | :arrow_down: |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `78.04% <0%> (-7.32%)` | :arrow_down: |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `57.64% <0%> (-4.71%)` | :arrow_down: |
| [...src/main/java/org/apache/dubbo/common/Version.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vVmVyc2lvbi5qYXZh) | `49.41% <0%> (-0.59%)` | :arrow_down: |
| [...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvUHJvdG9jb2wuamF2YQ==) | `66.66% <0%> (+0.83%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=footer). Last update [a35f942...ad6114e](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2822: Fix
FailbackClusterInvoker one risk of memory leak #2425
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
@beiwei30 @chickenlj
Would u pls have a look?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2822: Fix
FailbackClusterInvoker one risk of memory leak #2425
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=h1) Report
> Merging [#2822](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/a24289f244eafd46e0dc52e30377df485bfb69d0?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `43.9%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2822 +/- ##
==========================================
- Coverage 63.65% 63.61% -0.05%
==========================================
Files 577 577
Lines 25930 25949 +19
Branches 4541 4546 +5
==========================================
+ Hits 16507 16508 +1
- Misses 7264 7284 +20
+ Partials 2159 2157 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `88.88% <ø> (ø)` | :arrow_up: |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `58.92% <43.9%> (-27.56%)` | :arrow_down: |
| [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `73.52% <0%> (-11.77%)` | :arrow_down: |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `54.11% <0%> (-7.06%)` | :arrow_down: |
| [...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0Z1dHVyZUFkYXB0ZXIuamF2YQ==) | `58.06% <0%> (-6.46%)` | :arrow_down: |
| [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `51.42% <0%> (-5.72%)` | :arrow_down: |
| [...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQWN0aXZlTGltaXRGaWx0ZXIuamF2YQ==) | `83.33% <0%> (-5.56%)` | :arrow_down: |
| [.../org/apache/dubbo/remoting/ExecutionException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9FeGVjdXRpb25FeGNlcHRpb24uamF2YQ==) | `15.78% <0%> (-5.27%)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (-4.35%)` | :arrow_down: |
| [...exchange/support/header/HeaderExchangeHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZUhhbmRsZXIuamF2YQ==) | `55.81% <0%> (-2.33%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=footer). Last update [a24289f...2b2ecee](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] wangweiufofly commented on pull request
#2822: Fix FailbackClusterInvoker one risk of memory leak #2425
Posted by "wangweiufofly (GitHub)" <gi...@apache.org>.
Good idea. I've changed it.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2822: Fix
FailbackClusterInvoker one risk of memory leak #2425
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=h1) Report
> Merging [#2822](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/227a1699ac041b9e99e31ba3dfcff5d2307ee77b?src=pr&el=desc) will **increase** coverage by `0.23%`.
> The diff coverage is `68.78%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2822 +/- ##
==========================================
+ Coverage 64.04% 64.27% +0.23%
==========================================
Files 584 584
Lines 26050 26083 +33
Branches 4562 4567 +5
==========================================
+ Hits 16683 16765 +82
+ Misses 7190 7131 -59
- Partials 2177 2187 +10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9EdWJib1NodXRkb3duSG9vay5qYXZh) | `81.25% <ø> (+5.49%)` | :arrow_up: |
| [...rpc/cluster/loadbalance/RoundRobinLoadBalance.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbG9hZGJhbGFuY2UvUm91bmRSb2JpbkxvYWRCYWxhbmNlLmphdmE=) | `87.69% <ø> (+2.61%)` | :arrow_up: |
| [...notation/ReferenceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvYmVhbnMvZmFjdG9yeS9hbm5vdGF0aW9uL1JlZmVyZW5jZUFubm90YXRpb25CZWFuUG9zdFByb2Nlc3Nvci5qYXZh) | `76.38% <ø> (ø)` | :arrow_up: |
| [...ting/transport/netty/NettyBackedChannelBuffer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUJhY2tlZENoYW5uZWxCdWZmZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...pc/cluster/support/wrapper/MockClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC93cmFwcGVyL01vY2tDbHVzdGVySW52b2tlci5qYXZh) | `71.42% <ø> (ø)` | :arrow_up: |
| [...org/apache/dubbo/rpc/filter/ClassLoaderFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQ2xhc3NMb2FkZXJGaWx0ZXIuamF2YQ==) | `100% <ø> (ø)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvSW52b2tlci5qYXZh) | `71.66% <ø> (ø)` | :arrow_up: |
| [.../java/org/apache/dubbo/rpc/filter/TokenFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvVG9rZW5GaWx0ZXIuamF2YQ==) | `77.77% <ø> (ø)` | :arrow_up: |
| [...rpc/cluster/router/script/ScriptRouterFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3NjcmlwdC9TY3JpcHRSb3V0ZXJGYWN0b3J5LmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...va/org/apache/dubbo/rpc/filter/TpsLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvVHBzTGltaXRGaWx0ZXIuamF2YQ==) | `100% <ø> (ø)` | :arrow_up: |
| ... and [61 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=footer). Last update [227a169...232a4f8](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on pull request #2822:
Fix FailbackClusterInvoker one risk of memory leak #2425
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
1. DEFAULT_FAIL_CAPACITY_SIZE maybe changed to DEFAULT_FAILBACK_TASKS
2.1000 is to large to us. maybe 100 is enough.
:)
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2822: Fix
FailbackClusterInvoker one risk of memory leak #2425
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=h1) Report
> Merging [#2822](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/227a1699ac041b9e99e31ba3dfcff5d2307ee77b?src=pr&el=desc) will **increase** coverage by `0.31%`.
> The diff coverage is `69.36%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2822 +/- ##
==========================================
+ Coverage 64.04% 64.35% +0.31%
==========================================
Files 584 584
Lines 26050 26111 +61
Branches 4562 4564 +2
==========================================
+ Hits 16683 16805 +122
+ Misses 7190 7122 -68
- Partials 2177 2184 +7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9EdWJib1NodXRkb3duSG9vay5qYXZh) | `84.37% <ø> (+8.61%)` | :arrow_up: |
| [...rpc/cluster/loadbalance/RoundRobinLoadBalance.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbG9hZGJhbGFuY2UvUm91bmRSb2JpbkxvYWRCYWxhbmNlLmphdmE=) | `87.69% <ø> (+2.61%)` | :arrow_up: |
| [...notation/ReferenceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvYmVhbnMvZmFjdG9yeS9hbm5vdGF0aW9uL1JlZmVyZW5jZUFubm90YXRpb25CZWFuUG9zdFByb2Nlc3Nvci5qYXZh) | `76.38% <ø> (ø)` | :arrow_up: |
| [...ting/transport/netty/NettyBackedChannelBuffer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUJhY2tlZENoYW5uZWxCdWZmZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...pc/cluster/support/wrapper/MockClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC93cmFwcGVyL01vY2tDbHVzdGVySW52b2tlci5qYXZh) | `71.42% <ø> (ø)` | :arrow_up: |
| [...org/apache/dubbo/rpc/filter/ClassLoaderFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQ2xhc3NMb2FkZXJGaWx0ZXIuamF2YQ==) | `100% <ø> (ø)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvSW52b2tlci5qYXZh) | `71.66% <ø> (ø)` | :arrow_up: |
| [.../java/org/apache/dubbo/rpc/filter/TokenFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvVG9rZW5GaWx0ZXIuamF2YQ==) | `77.77% <ø> (ø)` | :arrow_up: |
| [...rpc/cluster/router/script/ScriptRouterFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3NjcmlwdC9TY3JpcHRSb3V0ZXJGYWN0b3J5LmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...va/org/apache/dubbo/rpc/filter/TpsLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvVHBzTGltaXRGaWx0ZXIuamF2YQ==) | `100% <ø> (ø)` | :arrow_up: |
| ... and [71 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=footer). Last update [227a169...232a4f8](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2822: Fix
FailbackClusterInvoker one risk of memory leak #2425
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=h1) Report
> Merging [#2822](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/a24289f244eafd46e0dc52e30377df485bfb69d0?src=pr&el=desc) will **decrease** coverage by `0.18%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2822 +/- ##
==========================================
- Coverage 63.76% 63.57% -0.19%
==========================================
Files 577 577
Lines 25930 25949 +19
Branches 4541 4546 +5
==========================================
- Hits 16533 16498 -35
- Misses 7245 7294 +49
- Partials 2152 2157 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `88.88% <ø> (ø)` | :arrow_up: |
| [...java/org/apache/dubbo/common/bytecode/Wrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYnl0ZWNvZGUvV3JhcHBlci5qYXZh) | `82.47% <100%> (ø)` | :arrow_up: |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `58.92% <43.9%> (-27.56%)` | :arrow_down: |
| [.../java/org/apache/dubbo/common/utils/PojoUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvUG9qb1V0aWxzLmphdmE=) | `70.26% <60%> (ø)` | :arrow_up: |
| [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `73.52% <0%> (-11.77%)` | :arrow_down: |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `43.42% <0%> (-10.53%)` | :arrow_down: |
| [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NoYW5uZWxXcmFwcGVkSW52b2tlci5qYXZh) | `41.66% <0%> (-8.34%)` | :arrow_down: |
| [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `51.42% <0%> (-5.72%)` | :arrow_down: |
| [.../org/apache/dubbo/remoting/ExecutionException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9FeGVjdXRpb25FeGNlcHRpb24uamF2YQ==) | `15.78% <0%> (-5.27%)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (-4.35%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=footer). Last update [a24289f...fef8612](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on pull request #2822:
Fix FailbackClusterInvoker one risk of memory leak #2425
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
maybe 'failbackTasks'
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on pull request #2822:
Fix FailbackClusterInvoker one risk of memory leak #2425
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Could u pls tell us why u rename the method and why u add the FixMethodOrder annotation?
:)
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] wangweiufofly commented on pull request
#2822: Fix FailbackClusterInvoker one risk of memory leak #2425
Posted by "wangweiufofly (GitHub)" <gi...@apache.org>.
Good idea. I've changed it
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on pull request #2822:
Fix FailbackClusterInvoker one risk of memory leak #2425
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
maybe 'failbacktasks' or sth
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] wangweiufofly commented on issue #2822:
Fix FailbackClusterInvoker one risk of memory leak #2425
Posted by "wangweiufofly (GitHub)" <gi...@apache.org>.
> Hi, @wangweiufofly
> I think we should add a ut for this feature.
> We should test the size of failback tasks and the retry times. :)
test case completed
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2822: Fix
FailbackClusterInvoker one risk of memory leak #2425
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=h1) Report
> Merging [#2822](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/227a1699ac041b9e99e31ba3dfcff5d2307ee77b?src=pr&el=desc) will **decrease** coverage by `0.41%`.
> The diff coverage is `43.9%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2822 +/- ##
==========================================
- Coverage 63.99% 63.57% -0.42%
==========================================
Files 584 577 -7
Lines 26050 25949 -101
Branches 4562 4546 -16
==========================================
- Hits 16671 16498 -173
- Misses 7200 7294 +94
+ Partials 2179 2157 -22
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `88.88% <ø> (ø)` | :arrow_up: |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `58.92% <43.9%> (-27.56%)` | :arrow_down: |
| [...org/apache/dubbo/rpc/cluster/merger/MapMerger.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbWVyZ2VyL01hcE1lcmdlci5qYXZh) | `62.5% <0%> (-37.5%)` | :arrow_down: |
| [...g/apache/dubbo/rpc/cluster/merger/ArrayMerger.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbWVyZ2VyL0FycmF5TWVyZ2VyLmphdmE=) | `68.42% <0%> (-31.58%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/cluster/merger/ListMerger.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbWVyZ2VyL0xpc3RNZXJnZXIuamF2YQ==) | `83.33% <0%> (-16.67%)` | :arrow_down: |
| [...org/apache/dubbo/rpc/cluster/merger/SetMerger.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbWVyZ2VyL1NldE1lcmdlci5qYXZh) | `83.33% <0%> (-16.67%)` | :arrow_down: |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9JbnZva2VUZWxuZXRIYW5kbGVyLmphdmE=) | `54.21% <0%> (-15.96%)` | :arrow_down: |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | :arrow_down: |
| [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `75% <0%> (-11.12%)` | :arrow_down: |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `43.42% <0%> (-10.53%)` | :arrow_down: |
| ... and [75 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=footer). Last update [227a169...5feea92](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on pull request #2822:
Fix FailbackClusterInvoker one risk of memory leak #2425
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Hi,
we have two files named dubbo.xsd.
Pls bring this config to both of them.
:)
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2822: Fix
FailbackClusterInvoker one risk of memory leak #2425
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=h1) Report
> Merging [#2822](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/a24289f244eafd46e0dc52e30377df485bfb69d0?src=pr&el=desc) will **decrease** coverage by `0.18%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2822 +/- ##
==========================================
- Coverage 63.76% 63.57% -0.19%
==========================================
Files 577 577
Lines 25930 25949 +19
Branches 4541 4546 +5
==========================================
- Hits 16533 16498 -35
- Misses 7245 7294 +49
- Partials 2152 2157 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `88.88% <ø> (ø)` | :arrow_up: |
| [...java/org/apache/dubbo/common/bytecode/Wrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYnl0ZWNvZGUvV3JhcHBlci5qYXZh) | `82.47% <100%> (ø)` | :arrow_up: |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `58.92% <43.9%> (-27.56%)` | :arrow_down: |
| [.../java/org/apache/dubbo/common/utils/PojoUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvUG9qb1V0aWxzLmphdmE=) | `70.26% <60%> (ø)` | :arrow_up: |
| [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `73.52% <0%> (-11.77%)` | :arrow_down: |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `43.42% <0%> (-10.53%)` | :arrow_down: |
| [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NoYW5uZWxXcmFwcGVkSW52b2tlci5qYXZh) | `41.66% <0%> (-8.34%)` | :arrow_down: |
| [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `51.42% <0%> (-5.72%)` | :arrow_down: |
| [.../org/apache/dubbo/remoting/ExecutionException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9FeGVjdXRpb25FeGNlcHRpb24uamF2YQ==) | `15.78% <0%> (-5.27%)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (-4.35%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=footer). Last update [a24289f...fef8612](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2822: Fix
FailbackClusterInvoker one risk of memory leak #2425
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=h1) Report
> Merging [#2822](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/227a1699ac041b9e99e31ba3dfcff5d2307ee77b?src=pr&el=desc) will **increase** coverage by `0.26%`.
> The diff coverage is `68.29%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2822 +/- ##
=========================================
+ Coverage 64.04% 64.3% +0.26%
=========================================
Files 584 584
Lines 26050 26057 +7
Branches 4562 4562
=========================================
+ Hits 16683 16756 +73
+ Misses 7190 7116 -74
- Partials 2177 2185 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9EdWJib1NodXRkb3duSG9vay5qYXZh) | `81.25% <ø> (+5.49%)` | :arrow_up: |
| [...rpc/cluster/loadbalance/RoundRobinLoadBalance.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbG9hZGJhbGFuY2UvUm91bmRSb2JpbkxvYWRCYWxhbmNlLmphdmE=) | `87.69% <ø> (+2.61%)` | :arrow_up: |
| [...notation/ReferenceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvYmVhbnMvZmFjdG9yeS9hbm5vdGF0aW9uL1JlZmVyZW5jZUFubm90YXRpb25CZWFuUG9zdFByb2Nlc3Nvci5qYXZh) | `76.38% <ø> (ø)` | :arrow_up: |
| [...ting/transport/netty/NettyBackedChannelBuffer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUJhY2tlZENoYW5uZWxCdWZmZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...pc/cluster/support/wrapper/MockClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC93cmFwcGVyL01vY2tDbHVzdGVySW52b2tlci5qYXZh) | `71.42% <ø> (ø)` | :arrow_up: |
| [...org/apache/dubbo/rpc/filter/ClassLoaderFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQ2xhc3NMb2FkZXJGaWx0ZXIuamF2YQ==) | `100% <ø> (ø)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvSW52b2tlci5qYXZh) | `71.66% <ø> (ø)` | :arrow_up: |
| [.../java/org/apache/dubbo/rpc/filter/TokenFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvVG9rZW5GaWx0ZXIuamF2YQ==) | `77.77% <ø> (ø)` | :arrow_up: |
| [...rpc/cluster/router/script/ScriptRouterFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3NjcmlwdC9TY3JpcHRSb3V0ZXJGYWN0b3J5LmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...va/org/apache/dubbo/rpc/filter/TpsLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvVHBzTGltaXRGaWx0ZXIuamF2YQ==) | `100% <ø> (ø)` | :arrow_up: |
| ... and [62 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=footer). Last update [227a169...232a4f8](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh closed pull request #2822: Fix
FailbackClusterInvoker one risk of memory leak #2425
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
[ pull request closed by carryxyh ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2822: Fix
FailbackClusterInvoker one risk of memory leak #2425
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Hi, @wangweiufofly
I think we should add a ut for this feature.
We should test the size of failback tasks and the retry times. :)
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] wangweiufofly commented on pull request
#2822: Fix FailbackClusterInvoker one risk of memory leak #2425
Posted by "wangweiufofly (GitHub)" <gi...@apache.org>.
Good idea. I've changed it.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] wangweiufofly commented on pull request
#2822: Fix FailbackClusterInvoker one risk of memory leak #2425
Posted by "wangweiufofly (GitHub)" <gi...@apache.org>.
Good idea. I've changed it.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2822: Fix
FailbackClusterInvoker one risk of memory leak #2425
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=h1) Report
> Merging [#2822](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/a24289f244eafd46e0dc52e30377df485bfb69d0?src=pr&el=desc) will **decrease** coverage by `0.1%`.
> The diff coverage is `43.9%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2822 +/- ##
==========================================
- Coverage 63.76% 63.65% -0.11%
==========================================
Files 577 577
Lines 25930 25949 +19
Branches 4541 4546 +5
==========================================
- Hits 16533 16518 -15
- Misses 7245 7273 +28
- Partials 2152 2158 +6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `88.88% <ø> (ø)` | :arrow_up: |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `58.92% <43.9%> (-27.56%)` | :arrow_down: |
| [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `73.52% <0%> (-11.77%)` | :arrow_down: |
| [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NoYW5uZWxXcmFwcGVkSW52b2tlci5qYXZh) | `41.66% <0%> (-8.34%)` | :arrow_down: |
| [...in/java/org/apache/dubbo/common/utils/JVMUtil.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvSlZNVXRpbC5qYXZh) | `73.58% <0%> (-7.55%)` | :arrow_down: |
| [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `51.42% <0%> (-5.72%)` | :arrow_down: |
| [...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQWN0aXZlTGltaXRGaWx0ZXIuamF2YQ==) | `83.33% <0%> (-5.56%)` | :arrow_down: |
| [.../org/apache/dubbo/remoting/ExecutionException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9FeGVjdXRpb25FeGNlcHRpb24uamF2YQ==) | `15.78% <0%> (-5.27%)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (-4.35%)` | :arrow_down: |
| [...ing/exchange/support/header/AbstractTimerTask.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9BYnN0cmFjdFRpbWVyVGFzay5qYXZh) | `66.66% <0%> (-4.17%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2822/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=footer). Last update [a24289f...31c930f](https://codecov.io/gh/apache/incubator-dubbo/pull/2822?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on pull request #2822:
Fix FailbackClusterInvoker one risk of memory leak #2425
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
I think u should assert that the logger contains the specific msg.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org