[GitHub] [pulsar-client-go] zzzming commented on a diff in pull request #800: ci: add makefile

[GitBox <gi...@apache.org>]

zzzming commented on code in PR #800:
URL: https://github.com/apache/pulsar-client-go/pull/800#discussion_r915347112


##########
Dockerfile:
##########
@@ -17,21 +17,19 @@
 # under the License.
 #
 
-ARG GO_VERSION=golang:1.15
-FROM apachepulsar/pulsar:2.8.2 as pulsar
-FROM $GO_VERSION as go
+ARG PULSAR_IMAGE=apachepulsar/pulsar:latest
+ARG GOLANG_IMAGE=golang:latest
+
+FROM $PULSAR_IMAGE as pulsar
+FROM $GOLANG_IMAGE
 
 RUN apt-get update && apt-get install -y openjdk-11-jre-headless ca-certificates
 
 COPY --from=pulsar /pulsar /pulsar
 
-### Add test scripts
+### Add pulsar config
 COPY integration-tests/certs /pulsar/certs
 COPY integration-tests/tokens /pulsar/tokens
-COPY integration-tests/standalone.conf /pulsar/conf
-COPY integration-tests/client.conf /pulsar/conf
-COPY integration-tests/.htpasswd /pulsar/conf
+COPY integration-tests/conf /pulsar/conf
+

Review Comment:
   Explicitly copying the file is easier to debug a problem if someone delete any file and not add any files that are not necessary.



##########
Dockerfile:
##########
@@ -17,21 +17,19 @@
 # under the License.
 #
 
-ARG GO_VERSION=golang:1.15
-FROM apachepulsar/pulsar:2.8.2 as pulsar
-FROM $GO_VERSION as go
+ARG PULSAR_IMAGE=apachepulsar/pulsar:latest
+ARG GOLANG_IMAGE=golang:latest

Review Comment:
   It'd better to keep the fixed version of base image. It is hard to trouble shoot problems if the latest points to a new version. That forces other PRs to deal with version problem.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org