You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Daan Hoogland <da...@gmail.com> on 2013/09/25 15:56:11 UTC

lb. maxconnections and haproxy.cfg

H,

I am trying to hack at the haproxy.cfg and encountered the following obstacle:

        if (!serviceProviderMap.containsKey(Service.Lb) &&
lbServiceCapabilityMap != null && !lbServiceCapabilityMap.isEmpty()) {
            maxconn = cmd.getMaxconnections();
            if (maxconn == null) {

maxconn=Integer.parseInt(_configDao.getValue(Config.NetworkLBHaproxyMaxConn.key()));
            }
        }

this means that max-concurrent-connections can only be set if no load
balancer functionality is used. this makes no sense to me as the value
is used in haproxy.cfg

Anyone has some background on this for me?

thanks,

Re: lb. maxconnections and haproxy.cfg

Posted by Daan Hoogland <da...@gmail.com>.
thanks guys

On Wed, Sep 25, 2013 at 5:56 PM, Bharat Kumar <bh...@citrix.com> wrote:
> Hi Daan you are correct.
>
> this check !serviceProviderMap should not be there. I think  i introduced this error while
> merging this fix.
>
> This is Fixed now.
>
>
> Regards,
> Bharat.
>
>
>
>
> On Sep 25, 2013, at 7:26 PM, Daan Hoogland <da...@gmail.com> wrote:
>
>> H,
>>
>> I am trying to hack at the haproxy.cfg and encountered the following obstacle:
>>
>>        if (!serviceProviderMap.containsKey(Service.Lb) &&
>> lbServiceCapabilityMap != null && !lbServiceCapabilityMap.isEmpty()) {
>>            maxconn = cmd.getMaxconnections();
>>            if (maxconn == null) {
>>
>> maxconn=Integer.parseInt(_configDao.getValue(Config.NetworkLBHaproxyMaxConn.key()));
>>            }
>>        }
>>
>> this means that max-concurrent-connections can only be set if no load
>> balancer functionality is used. this makes no sense to me as the value
>> is used in haproxy.cfg
>>
>> Anyone has some background on this for me?
>>
>> thanks,
>

Re: lb. maxconnections and haproxy.cfg

Posted by Bharat Kumar <bh...@citrix.com>.
Hi Daan you are correct. 

this check !serviceProviderMap should not be there. I think  i introduced this error while 
merging this fix. 

This is Fixed now.


Regards,
Bharat.




On Sep 25, 2013, at 7:26 PM, Daan Hoogland <da...@gmail.com> wrote:

> H,
> 
> I am trying to hack at the haproxy.cfg and encountered the following obstacle:
> 
>        if (!serviceProviderMap.containsKey(Service.Lb) &&
> lbServiceCapabilityMap != null && !lbServiceCapabilityMap.isEmpty()) {
>            maxconn = cmd.getMaxconnections();
>            if (maxconn == null) {
> 
> maxconn=Integer.parseInt(_configDao.getValue(Config.NetworkLBHaproxyMaxConn.key()));
>            }
>        }
> 
> this means that max-concurrent-connections can only be set if no load
> balancer functionality is used. this makes no sense to me as the value
> is used in haproxy.cfg
> 
> Anyone has some background on this for me?
> 
> thanks,


Re: lb. maxconnections and haproxy.cfg

Posted by Abhinandan Prateek <Ab...@citrix.com>.
Yes that condition will mask maxconn ever getting set, fixed.

On 25/09/13 7:26 pm, "Daan Hoogland" <da...@gmail.com> wrote:

>H,
>
>I am trying to hack at the haproxy.cfg and encountered the following
>obstacle:
>
>        if (!serviceProviderMap.containsKey(Service.Lb) &&
>lbServiceCapabilityMap != null && !lbServiceCapabilityMap.isEmpty()) {
>            maxconn = cmd.getMaxconnections();
>            if (maxconn == null) {
>
>maxconn=Integer.parseInt(_configDao.getValue(Config.NetworkLBHaproxyMaxCon
>n.key()));
>            }
>        }
>
>this means that max-concurrent-connections can only be set if no load
>balancer functionality is used. this makes no sense to me as the value
>is used in haproxy.cfg
>
>Anyone has some background on this for me?
>
>thanks,