You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "pegasas (via GitHub)" <gi...@apache.org> on 2023/08/31 13:09:52 UTC
[GitHub] [incubator-uniffle] pegasas opened a new pull request, #1184: [Improvement] Refactor the writer code with builder pattern
pegasas opened a new pull request, #1184:
URL: https://github.com/apache/incubator-uniffle/pull/1184
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
(Please outline the changes and how this PR fixes the issue.)
### Why are the changes needed?
(Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, describe the bug.)
Fix: # (issue)
### Does this PR introduce _any_ user-facing change?
(Please list the user-facing changes introduced by your change, including
1. Change in user-facing APIs.
2. Addition or removal of property keys.)
No.
### How was this patch tested?
(Please test your changes, and provide instructions on how to test it:
1. If you add a feature or fix a bug, add a test to cover your changes.
2. If you fix a flaky test, repeat it for many times to prove it works.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #1184: [Improvement] Refactor the writer code with builder pattern
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1184:
URL: https://github.com/apache/incubator-uniffle/pull/1184#issuecomment-1701164963
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1184?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1184](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1184?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cdaf100) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/164e0d02456763f661fb55cc47459312bf4e80b4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (164e0d0) will **increase** coverage by `1.03%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #1184 +/- ##
============================================
+ Coverage 53.63% 54.66% +1.03%
+ Complexity 2581 2571 -10
============================================
Files 391 370 -21
Lines 22407 20046 -2361
Branches 1875 1869 -6
============================================
- Hits 12018 10959 -1059
+ Misses 9683 8457 -1226
+ Partials 706 630 -76
```
| [Files Changed](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...che/uniffle/client/impl/ShuffleReadClientImpl.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC9pbXBsL1NodWZmbGVSZWFkQ2xpZW50SW1wbC5qYXZh) | `62.13% <0.00%> (-16.23%)` | :arrow_down: |
... and [24 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1184/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] pegasas closed pull request #1184: [Improvement] Refactor the writer code with builder pattern
Posted by "pegasas (via GitHub)" <gi...@apache.org>.
pegasas closed pull request #1184: [Improvement] Refactor the writer code with builder pattern
URL: https://github.com/apache/incubator-uniffle/pull/1184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] pegasas closed pull request #1184: [Improvement] Refactor the writer code with builder pattern
Posted by "pegasas (via GitHub)" <gi...@apache.org>.
pegasas closed pull request #1184: [Improvement] Refactor the writer code with builder pattern
URL: https://github.com/apache/incubator-uniffle/pull/1184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org