You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Sian January <si...@googlemail.com> on 2006/11/13 18:30:00 UTC
[jira] Patch available setting
Hi,
I have just discovered that it's not possible for a contributor to set
"Patch available" on a JIRA unless they reported it. (I'm not sure about
committers as I'm not one...) I imagine this is to stop people coming in
and editing other details on the JIRA, so I can see that it makes sense. My
question is, what is the best thing to do if I attach a patch to a JIRA and
I can't set "Patch available"? I can think of three alternatives at the
moment:
1. Assume that the reporter will notice and set it themselves (or commit the
fix if they're also a comitter)
2. E-mail the reporter privately
3. Post to the mailing list
Or a fourth alternative would be a combination of the above where the person
who contributed the patch waits a few days before doing either 2 or 3. Any
thoughts on what would be best?
Thanks,
Sian
--
Sian January
IBM Java Technology Centre, UK
Re: [jira] Patch available setting
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
Tim Ellison wrote:
> Geir Magnusson Jr. wrote:
>> I thought we had it configured that when a JIRA is modified, the
>> reporter is notified directly... I'm not sure that really helps though.
>> I wonder if we should just open things up a bit and let any user modify
>> a JIRA and see what happens.
>
> +1 Provided we don't become a spam target, I'm all for letting anyone
> who has a JIRA account modify an issue.
Yes - clearly it requires an account. We'd never leave it open...
geir
>
> Regards,
> Tim
>
Re: [jira] Patch available setting
Posted by Tim Ellison <t....@gmail.com>.
Geir Magnusson Jr. wrote:
> I thought we had it configured that when a JIRA is modified, the
> reporter is notified directly... I'm not sure that really helps though.
> I wonder if we should just open things up a bit and let any user modify
> a JIRA and see what happens.
+1 Provided we don't become a spam target, I'm all for letting anyone
who has a JIRA account modify an issue.
Regards,
Tim
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
Re: [jira] Patch available setting
Posted by Egor Pasko <eg...@gmail.com>.
On the 0x223 day of Apache Harmony Geir Magnusson, Jr. wrote:
> Egor Pasko wrote:
> > On the 0x223 day of Apache Harmony Geir Magnusson, Jr. wrote:
> >> Egor Pasko wrote:
> >>> On the 0x222 day of Apache Harmony Geir Magnusson, Jr. wrote:
> >>>> I thought we had it configured that when a JIRA is modified, the
> >>>> reporter is notified directly... I'm not sure that really helps
> >>>> though. I wonder if we should just open things up a bit and let any
> >>>> user modify a JIRA and see what happens.
> >>> reporters are notified, that's right
> >>> But what if <reporter>=<patch publisher>? Then someone still needs to
> >>> review. Sometimes, reporters are not familiar with the components
> >>> fixed, someone needs to pick up a review in this case too.
> >> That's why I watch things I'm interested in.
> >>
> >>> I just look at all Harmony JIRA notifications. There are a lot, but
> >>> most can be safely skipped by subject.
> >> Right - do a watch on the JIRAs you are interested in - they come to
> >> you directly, not to the project JIRA stream.
> > Is there any other way to be notified with new issues than to
> > subscribe for the whole JIRA stream? I would love to use it.
>
> I want to be sure to get the whole stream, and then just filter for
> things I want to look for.
>
> Unless this is something that lots of people need - having a separate
> "new JIRA" mail stream, I think that you might want to try that :)
You knew that! I am like lots of people dying from a separate "new
JIRA" stream desire. Thanks for suggestion, I should heve found that,
pretty obvious.
Now back to fighting this killing-me-outlook that has a
limit-to-number-of-filters feature that I constantly suffer from.
> geir
>
> > P.S: "watch" is a good feature, I have been using it.
> >
> >> geir
> >>
> >>>> geir
> >>>>
> >>>> Sian January wrote:
> >>>>> Hi,
> >>>>> I have just discovered that it's not possible for a contributor to
> >>>>> set
> >>>>> "Patch available" on a JIRA unless they reported it. (I'm not sure about
> >>>>> committers as I'm not one...) I imagine this is to stop people coming in
> >>>>> and editing other details on the JIRA, so I can see that it makes
> >>>>> sense. My
> >>>>> question is, what is the best thing to do if I attach a patch to a JIRA and
> >>>>> I can't set "Patch available"? I can think of three alternatives at the
> >>>>> moment:
> >>>>> 1. Assume that the reporter will notice and set it themselves (or
> >>>>> commit the
> >>>>> fix if they're also a comitter)
> >>>>> 2. E-mail the reporter privately
> >>>>> 3. Post to the mailing list
> >>>>> Or a fourth alternative would be a combination of the above where
> >>>>> the person
> >>>>> who contributed the patch waits a few days before doing either 2 or 3. Any
> >>>>> thoughts on what would be best?
> >>>>> Thanks,
> >>>>> Sian
> >>>>>
> >>>>
> >
>
--
Egor Pasko
Re: [jira] Patch available setting
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
Egor Pasko wrote:
> On the 0x223 day of Apache Harmony Geir Magnusson, Jr. wrote:
>> Egor Pasko wrote:
>>> On the 0x222 day of Apache Harmony Geir Magnusson, Jr. wrote:
>>>> I thought we had it configured that when a JIRA is modified, the
>>>> reporter is notified directly... I'm not sure that really helps
>>>> though. I wonder if we should just open things up a bit and let any
>>>> user modify a JIRA and see what happens.
>>> reporters are notified, that's right
>>> But what if <reporter>=<patch publisher>? Then someone still needs to
>>> review. Sometimes, reporters are not familiar with the components
>>> fixed, someone needs to pick up a review in this case too.
>> That's why I watch things I'm interested in.
>>
>>> I just look at all Harmony JIRA notifications. There are a lot, but
>>> most can be safely skipped by subject.
>> Right - do a watch on the JIRAs you are interested in - they come to
>> you directly, not to the project JIRA stream.
>
> Is there any other way to be notified with new issues than to
> subscribe for the whole JIRA stream? I would love to use it.
I want to be sure to get the whole stream, and then just filter for
things I want to look for.
Unless this is something that lots of people need - having a separate
"new JIRA" mail stream, I think that you might want to try that :)
geir
>
> P.S: "watch" is a good feature, I have been using it.
>
>> geir
>>
>>>> geir
>>>>
>>>> Sian January wrote:
>>>>> Hi,
>>>>> I have just discovered that it's not possible for a contributor to
>>>>> set
>>>>> "Patch available" on a JIRA unless they reported it. (I'm not sure about
>>>>> committers as I'm not one...) I imagine this is to stop people coming in
>>>>> and editing other details on the JIRA, so I can see that it makes
>>>>> sense. My
>>>>> question is, what is the best thing to do if I attach a patch to a JIRA and
>>>>> I can't set "Patch available"? I can think of three alternatives at the
>>>>> moment:
>>>>> 1. Assume that the reporter will notice and set it themselves (or
>>>>> commit the
>>>>> fix if they're also a comitter)
>>>>> 2. E-mail the reporter privately
>>>>> 3. Post to the mailing list
>>>>> Or a fourth alternative would be a combination of the above where
>>>>> the person
>>>>> who contributed the patch waits a few days before doing either 2 or 3. Any
>>>>> thoughts on what would be best?
>>>>> Thanks,
>>>>> Sian
>>>>>
>>>>
>
Re: [jira] Patch available setting
Posted by Egor Pasko <eg...@gmail.com>.
On the 0x223 day of Apache Harmony Geir Magnusson, Jr. wrote:
> Egor Pasko wrote:
> > On the 0x222 day of Apache Harmony Geir Magnusson, Jr. wrote:
> >> I thought we had it configured that when a JIRA is modified, the
> >> reporter is notified directly... I'm not sure that really helps
> >> though. I wonder if we should just open things up a bit and let any
> >> user modify a JIRA and see what happens.
> > reporters are notified, that's right
> > But what if <reporter>=<patch publisher>? Then someone still needs to
> > review. Sometimes, reporters are not familiar with the components
> > fixed, someone needs to pick up a review in this case too.
>
> That's why I watch things I'm interested in.
>
> > I just look at all Harmony JIRA notifications. There are a lot, but
> > most can be safely skipped by subject.
>
> Right - do a watch on the JIRAs you are interested in - they come to
> you directly, not to the project JIRA stream.
Is there any other way to be notified with new issues than to
subscribe for the whole JIRA stream? I would love to use it.
P.S: "watch" is a good feature, I have been using it.
> geir
>
> >
> >> geir
> >>
> >> Sian January wrote:
> >>> Hi,
> >>> I have just discovered that it's not possible for a contributor to
> >>> set
> >>> "Patch available" on a JIRA unless they reported it. (I'm not sure about
> >>> committers as I'm not one...) I imagine this is to stop people coming in
> >>> and editing other details on the JIRA, so I can see that it makes
> >>> sense. My
> >>> question is, what is the best thing to do if I attach a patch to a JIRA and
> >>> I can't set "Patch available"? I can think of three alternatives at the
> >>> moment:
> >>> 1. Assume that the reporter will notice and set it themselves (or
> >>> commit the
> >>> fix if they're also a comitter)
> >>> 2. E-mail the reporter privately
> >>> 3. Post to the mailing list
> >>> Or a fourth alternative would be a combination of the above where
> >>> the person
> >>> who contributed the patch waits a few days before doing either 2 or 3. Any
> >>> thoughts on what would be best?
> >>> Thanks,
> >>> Sian
> >>>
> >>
> >>
> >
>
--
Egor Pasko
Re: [jira] Patch available setting
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
Egor Pasko wrote:
> On the 0x222 day of Apache Harmony Geir Magnusson, Jr. wrote:
>> I thought we had it configured that when a JIRA is modified, the
>> reporter is notified directly... I'm not sure that really helps
>> though. I wonder if we should just open things up a bit and let any
>> user modify a JIRA and see what happens.
>
> reporters are notified, that's right
>
> But what if <reporter>=<patch publisher>? Then someone still needs to
> review. Sometimes, reporters are not familiar with the components
> fixed, someone needs to pick up a review in this case too.
That's why I watch things I'm interested in.
>
> I just look at all Harmony JIRA notifications. There are a lot, but
> most can be safely skipped by subject.
Right - do a watch on the JIRAs you are interested in - they come to you
directly, not to the project JIRA stream.
geir
>
>> geir
>>
>> Sian January wrote:
>>> Hi,
>>> I have just discovered that it's not possible for a contributor to
>>> set
>>> "Patch available" on a JIRA unless they reported it. (I'm not sure about
>>> committers as I'm not one...) I imagine this is to stop people coming in
>>> and editing other details on the JIRA, so I can see that it makes
>>> sense. My
>>> question is, what is the best thing to do if I attach a patch to a JIRA and
>>> I can't set "Patch available"? I can think of three alternatives at the
>>> moment:
>>> 1. Assume that the reporter will notice and set it themselves (or
>>> commit the
>>> fix if they're also a comitter)
>>> 2. E-mail the reporter privately
>>> 3. Post to the mailing list
>>> Or a fourth alternative would be a combination of the above where
>>> the person
>>> who contributed the patch waits a few days before doing either 2 or 3. Any
>>> thoughts on what would be best?
>>> Thanks,
>>> Sian
>>>
>>
>>
>
Re: [jira] Patch available setting
Posted by Alexey Petrenko <al...@gmail.com>.
15 Nov 2006 11:31:39 +0600, Egor Pasko <eg...@gmail.com>:
> On the 0x222 day of Apache Harmony Geir Magnusson, Jr. wrote:
> > I thought we had it configured that when a JIRA is modified, the
> > reporter is notified directly... I'm not sure that really helps
> > though. I wonder if we should just open things up a bit and let any
> > user modify a JIRA and see what happens.
>
> reporters are notified, that's right
>
> But what if <reporter>=<patch publisher>? Then someone still needs to
> review.
The patch will be reviewed by committer at least.
> Sometimes, reporters are not familiar with the components
> fixed, someone needs to pick up a review in this case too.
>
> I just look at all Harmony JIRA notifications. There are a lot, but
> most can be safely skipped by subject.
That's good approach too.
Thanks for doing this!
SY, Alexey
> > Sian January wrote:
> > > Hi,
> > > I have just discovered that it's not possible for a contributor to
> > > set
> > > "Patch available" on a JIRA unless they reported it. (I'm not sure about
> > > committers as I'm not one...) I imagine this is to stop people coming in
> > > and editing other details on the JIRA, so I can see that it makes
> > > sense. My
> > > question is, what is the best thing to do if I attach a patch to a JIRA and
> > > I can't set "Patch available"? I can think of three alternatives at the
> > > moment:
> > > 1. Assume that the reporter will notice and set it themselves (or
> > > commit the
> > > fix if they're also a comitter)
> > > 2. E-mail the reporter privately
> > > 3. Post to the mailing list
> > > Or a fourth alternative would be a combination of the above where
> > > the person
> > > who contributed the patch waits a few days before doing either 2 or 3. Any
> > > thoughts on what would be best?
> > > Thanks,
> > > Sian
> > >
> >
> >
> >
>
> --
> Egor Pasko
>
>
Re: [jira] Patch available setting
Posted by Egor Pasko <eg...@gmail.com>.
On the 0x222 day of Apache Harmony Geir Magnusson, Jr. wrote:
> I thought we had it configured that when a JIRA is modified, the
> reporter is notified directly... I'm not sure that really helps
> though. I wonder if we should just open things up a bit and let any
> user modify a JIRA and see what happens.
reporters are notified, that's right
But what if <reporter>=<patch publisher>? Then someone still needs to
review. Sometimes, reporters are not familiar with the components
fixed, someone needs to pick up a review in this case too.
I just look at all Harmony JIRA notifications. There are a lot, but
most can be safely skipped by subject.
>
> geir
>
> Sian January wrote:
> > Hi,
> > I have just discovered that it's not possible for a contributor to
> > set
> > "Patch available" on a JIRA unless they reported it. (I'm not sure about
> > committers as I'm not one...) I imagine this is to stop people coming in
> > and editing other details on the JIRA, so I can see that it makes
> > sense. My
> > question is, what is the best thing to do if I attach a patch to a JIRA and
> > I can't set "Patch available"? I can think of three alternatives at the
> > moment:
> > 1. Assume that the reporter will notice and set it themselves (or
> > commit the
> > fix if they're also a comitter)
> > 2. E-mail the reporter privately
> > 3. Post to the mailing list
> > Or a fourth alternative would be a combination of the above where
> > the person
> > who contributed the patch waits a few days before doing either 2 or 3. Any
> > thoughts on what would be best?
> > Thanks,
> > Sian
> >
>
>
>
--
Egor Pasko
Re: [jira] Patch available setting
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
I thought we had it configured that when a JIRA is modified, the
reporter is notified directly... I'm not sure that really helps though.
I wonder if we should just open things up a bit and let any user
modify a JIRA and see what happens.
geir
Sian January wrote:
> Hi,
>
> I have just discovered that it's not possible for a contributor to set
> "Patch available" on a JIRA unless they reported it. (I'm not sure about
> committers as I'm not one...) I imagine this is to stop people coming in
> and editing other details on the JIRA, so I can see that it makes
> sense. My
> question is, what is the best thing to do if I attach a patch to a JIRA and
> I can't set "Patch available"? I can think of three alternatives at the
> moment:
>
> 1. Assume that the reporter will notice and set it themselves (or commit
> the
> fix if they're also a comitter)
> 2. E-mail the reporter privately
> 3. Post to the mailing list
>
> Or a fourth alternative would be a combination of the above where the
> person
> who contributed the patch waits a few days before doing either 2 or 3. Any
> thoughts on what would be best?
>
> Thanks,
>
> Sian
>
Re: [jira] Patch available setting
Posted by Egor Pasko <eg...@gmail.com>.
On the 0x221 day of Apache Harmony Alexei Fedotov wrote:
> Guys,
>
> I was trying to compare public announcements of new patches with
> private ones. The point of announcing new patches on harmony-dev@ is
> the following: anyone is welcome to verify a new patch.
>
> If no volunteers are willing to do so, then a committer or a bug
> submitter will do the job.
subscribing to JIRA notifications helps to catch new patches...and
comment them directly in JIRA. I do it like that.
> On 11/14/06, Salikh Zakirov <Sa...@intel.com> wrote:
> > Alexey Petrenko wrote:
> > > So I think that *require* from issue creator to check the fix *before*
> > > not the best solution.
> >
> > Since noone on earth can prevent you from submitting your patch to a new JIRA and link
> > it to the original one, this is not a *real* requirement. I guess this is just a hint to proper
> > patch review / verification process.
> >
> > In any case, I do not see much of a problem.
> >
> >
>
>
> --
> Thank you,
> Alexei
>
--
Egor Pasko
Re: [jira] Patch available setting
Posted by Alexei Fedotov <al...@gmail.com>.
Guys,
I was trying to compare public announcements of new patches with
private ones. The point of announcing new patches on harmony-dev@ is
the following: anyone is welcome to verify a new patch.
If no volunteers are willing to do so, then a committer or a bug
submitter will do the job.
Thanks, Alexei
On 11/14/06, Salikh Zakirov <Sa...@intel.com> wrote:
> Alexey Petrenko wrote:
> > So I think that *require* from issue creator to check the fix *before*
> > not the best solution.
>
> Since noone on earth can prevent you from submitting your patch to a new JIRA and link
> it to the original one, this is not a *real* requirement. I guess this is just a hint to proper
> patch review / verification process.
>
> In any case, I do not see much of a problem.
>
>
--
Thank you,
Alexei
Re: [jira] Patch available setting
Posted by Salikh Zakirov <Sa...@Intel.com>.
Alexey Petrenko wrote:
> So I think that *require* from issue creator to check the fix *before*
> not the best solution.
Since noone on earth can prevent you from submitting your patch to a new JIRA and link
it to the original one, this is not a *real* requirement. I guess this is just a hint to proper
patch review / verification process.
In any case, I do not see much of a problem.
Re: [jira] Patch available setting
Posted by Alexey Petrenko <al...@gmail.com>.
>From the one hand, fix checking by issue creator is good...
But from the other hand, bug submitter could be a person who is using
Harmony snapshot and does not know how to apply the patch and build
Harmony...
It is also possible that issue creator is not subscribed to Harmony dev list...
So I think that *require* from issue creator to check the fix *before*
not the best solution.
Let's allow to set this field to everybody and clear it for committers
(if it's possible :)
In this case "resolution provider" could set the property and
committer could clear it if he does not like the fix...
SY, Alexey
2006/11/14, Alexei Fedotov <al...@gmail.com>:
> Sian,
> This is a good catch. I have the following justification for 3. I
> think it is better process when a bug submitter validates a patch
> *before* commit to ensure that it is good. Also it validates the patch
> *after*. This worth to be requested via public alias.
>
> Why a bug submitter should do a pre-commit check? He has most interest
> in the bug resolution.
>
> Thanks!
>
> On 11/13/06, Sian January <si...@googlemail.com> wrote:
> > Hi,
> >
> > I have just discovered that it's not possible for a contributor to set
> > "Patch available" on a JIRA unless they reported it. (I'm not sure about
> > committers as I'm not one...) I imagine this is to stop people coming in
> > and editing other details on the JIRA, so I can see that it makes sense. My
> > question is, what is the best thing to do if I attach a patch to a JIRA and
> > I can't set "Patch available"? I can think of three alternatives at the
> > moment:
> >
> > 1. Assume that the reporter will notice and set it themselves (or commit the
> > fix if they're also a comitter)
> > 2. E-mail the reporter privately
> > 3. Post to the mailing list
> >
> > Or a fourth alternative would be a combination of the above where the person
> > who contributed the patch waits a few days before doing either 2 or 3. Any
> > thoughts on what would be best?
> >
> > Thanks,
> >
> > Sian
> >
> > --
> > Sian January
> >
> > IBM Java Technology Centre, UK
> >
> >
>
>
> --
> Thank you,
> Alexei
>
Re: [jira] Patch available setting
Posted by Alexei Fedotov <al...@gmail.com>.
Sian,
This is a good catch. I have the following justification for 3. I
think it is better process when a bug submitter validates a patch
*before* commit to ensure that it is good. Also it validates the patch
*after*. This worth to be requested via public alias.
Why a bug submitter should do a pre-commit check? He has most interest
in the bug resolution.
Thanks!
On 11/13/06, Sian January <si...@googlemail.com> wrote:
> Hi,
>
> I have just discovered that it's not possible for a contributor to set
> "Patch available" on a JIRA unless they reported it. (I'm not sure about
> committers as I'm not one...) I imagine this is to stop people coming in
> and editing other details on the JIRA, so I can see that it makes sense. My
> question is, what is the best thing to do if I attach a patch to a JIRA and
> I can't set "Patch available"? I can think of three alternatives at the
> moment:
>
> 1. Assume that the reporter will notice and set it themselves (or commit the
> fix if they're also a comitter)
> 2. E-mail the reporter privately
> 3. Post to the mailing list
>
> Or a fourth alternative would be a combination of the above where the person
> who contributed the patch waits a few days before doing either 2 or 3. Any
> thoughts on what would be best?
>
> Thanks,
>
> Sian
>
> --
> Sian January
>
> IBM Java Technology Centre, UK
>
>
--
Thank you,
Alexei