You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by "Kriskras99 (via GitHub)" <gi...@apache.org> on 2025/08/10 19:58:35 UTC
[I] Serde human readable seems wrong? [avro-rs]
Kriskras99 opened a new issue, #254:
URL: https://github.com/apache/avro-rs/issues/254
Looking at the documentation of [`Serializer::is_human_readable`](https://docs.rs/serde/latest/serde/trait.Serializer.html#method.is_human_readable) and [`Deserializer::is_human_readable`](https://docs.rs/serde/latest/serde/trait.Deserializer.html#method.is_human_readable) it seems to me that `is_human_readable` is intended to be used by the type that is being (de)serialized to know if the format is human readable.
As Avro is not a human readable format, this should always be `false` (it currently defaults to `true`) and this API to change the implementation should be removed.
Doing this is a breaking change, so might be nice to combine with the async work (if we implement that).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Serde human readable seems wrong? [avro-rs]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on issue #254:
URL: https://github.com/apache/avro-rs/issues/254#issuecomment-3172865256
This was requested by an user - https://issues.apache.org/jira/browse/AVRO-3747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Serde human readable seems wrong? [avro-rs]
Posted by "Kriskras99 (via GitHub)" <gi...@apache.org>.
Kriskras99 commented on issue #254:
URL: https://github.com/apache/avro-rs/issues/254#issuecomment-3172877806
Looking at that issue it seems that the user needed `is_human_readable = false` so that timestamps would be encoded as milliseconds in Avro, while JSON would use the RFC3389 string. Which is how `is_human_readable` is supposed to work.
However changing the default could potentially be a major breaking change as a type serialized with `is_human_readable = true` would potentially not deserialize with `is_human_readable = false`. The advantage of changing the default to `false` would be that the resulting serialisation would be more compact by default, and we can keep the override for users depending on the "wrong" behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Serde human readable seems wrong? [avro-rs]
Posted by "Kriskras99 (via GitHub)" <gi...@apache.org>.
Kriskras99 commented on issue #254:
URL: https://github.com/apache/avro-rs/issues/254#issuecomment-3458604580
Closed by #325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Serde human readable seems wrong? [avro-rs]
Posted by "Kriskras99 (via GitHub)" <gi...@apache.org>.
Kriskras99 closed issue #254: Serde human readable seems wrong?
URL: https://github.com/apache/avro-rs/issues/254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org