[GitHub] [trafficserver] shinrich commented on a diff in pull request #9518: Fix, add metrics testing to tls_tunnel Au test.

["shinrich (via GitHub)" <gi...@apache.org>]

shinrich commented on code in PR #9518:
URL: https://github.com/apache/trafficserver/pull/9518#discussion_r1157323637


##########
proxy/http/HttpTransact.cc:
##########
@@ -5723,9 +5723,13 @@ HttpTransact::initialize_state_variables_from_request(State *s, HTTPHdr *obsolet
     s->cache_info.action = CACHE_DO_NO_ACTION;
   }
 
+  bool do_increment_stat = (0 == s->method);

Review Comment:
   So without this check unset methods count towards tunnel.   Won't this remove some legitimate tunnel counts like tr_pass tunnels?  In what cases are we seeing unset methods?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org