[GitHub] [incubator-superset] graceguo-supercat commented on issue #6997: [Design Proposal] New Dashboard Creation flow

[GitBox <gi...@apache.org>]

graceguo-supercat commented on issue #6997: [Design Proposal] New Dashboard Creation flow
URL: https://github.com/apache/incubator-superset/issues/6997#issuecomment-471408379
 
 
   Hi @dorq Thanks for the proposal, I like it. Here is my input from engineering point of view:
   
   - `We add Sort and Filter capabilities at the top of this list (sticky at top of panel).` 
   Current dashboard editor had sort and filter capabilities for the chart lists, right? is there any difference from current feature?
   
   - I noticed there is a preview in the chart list, which is not available in the current dashboard. We didn't implement mostly from performance concerns. When user open edit mode, the chart list shows all the charts that owned by the user, for airbnb users it may a few hundred items, and each chart is a query (sometimes may be cached data) to backend. So when to send query, send how many queries, how to handle user scrolling in the chart list, etc., to implementation these need a lot of intelligence.  Otherwise user will get stuck waiting for query running and chart render, and the editing dashboard could become unusable.  
   
   If you decided to implement this chart preview, please offer a choice to disable it, and disable should be default state, so that user won't get stuck when we release the new version. If user really want to see chart preview, they can manually enable it. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org