You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/03/01 09:33:53 UTC
[GitHub] [incubator-pekko-management] mdedetrich commented on a diff in pull request #21: Remove FQCN boilerplate
mdedetrich commented on code in PR #21:
URL: https://github.com/apache/incubator-pekko-management/pull/21#discussion_r1121410465
##########
integration-test/kubernetes-api/src/main/scala/org/apache/pekko/cluster/bootstrap/DemoApp.scala:
##########
@@ -13,16 +13,16 @@
package org.apache.pekko.cluster.bootstrap
-import org.apache.pekko.actor.{ Actor, ActorLogging, ActorSystem, Props }
-import org.apache.pekko.cluster.ClusterEvent.ClusterDomainEvent
-import org.apache.pekko.cluster.{ Cluster, ClusterEvent }
-import org.apache.pekko.http.scaladsl.Http
-import org.apache.pekko.http.scaladsl.model._
-import org.apache.pekko.http.scaladsl.server.Directives._
-import org.apache.pekko.management.cluster.bootstrap.ClusterBootstrap
-import org.apache.pekko.management.scaladsl.PekkoManagement
+import org.apache.pekko
+import pekko.actor.{ Actor, ActorLogging, ActorSystem, Props }
+import pekko.cluster.ClusterEvent.ClusterDomainEvent
+import pekko.cluster.{ Cluster, ClusterEvent }
+import pekko.http.scaladsl.Http
+import pekko.http.scaladsl.model._
+import pekko.http.scaladsl.server.Directives._
+import pekko.management.cluster.bootstrap.ClusterBootstrap
//#start-akka-management
-
Review Comment:
@pjfanning Pinging you here so you are aware because the change you done in https://github.com/apache/incubator-pekko-management/pull/17 caused a regression.
The `//#` are special comments that are used by paradox for docs. Removing the `import org.apache.pekko.management.scaladsl.PekkoManagement` statement from between the `//#start-akka-management` meant that the generated paradox docs would be missing the import statement.
For future similar PR's in other projects its probably easiest to just change the imports from `import akka` to `import org.apache.pekko` without re-organizing everything. Otherwise you have to manually inspect the imports to make sure that you don't break the docs (this is what I have been and its somewhat painful and takes many hours).
##########
integration-test/kubernetes-api/src/main/scala/org/apache/pekko/cluster/bootstrap/DemoApp.scala:
##########
@@ -13,16 +13,16 @@
package org.apache.pekko.cluster.bootstrap
-import org.apache.pekko.actor.{ Actor, ActorLogging, ActorSystem, Props }
-import org.apache.pekko.cluster.ClusterEvent.ClusterDomainEvent
-import org.apache.pekko.cluster.{ Cluster, ClusterEvent }
-import org.apache.pekko.http.scaladsl.Http
-import org.apache.pekko.http.scaladsl.model._
-import org.apache.pekko.http.scaladsl.server.Directives._
-import org.apache.pekko.management.cluster.bootstrap.ClusterBootstrap
-import org.apache.pekko.management.scaladsl.PekkoManagement
+import org.apache.pekko
+import pekko.actor.{ Actor, ActorLogging, ActorSystem, Props }
+import pekko.cluster.ClusterEvent.ClusterDomainEvent
+import pekko.cluster.{ Cluster, ClusterEvent }
+import pekko.http.scaladsl.Http
+import pekko.http.scaladsl.model._
+import pekko.http.scaladsl.server.Directives._
+import pekko.management.cluster.bootstrap.ClusterBootstrap
//#start-akka-management
-
Review Comment:
@pjfanning Pinging you here so you are aware because the change you done in https://github.com/apache/incubator-pekko-management/pull/17 caused a regression in docs.
The `//#` are special comments that are used by paradox for docs. Removing the `import org.apache.pekko.management.scaladsl.PekkoManagement` statement from between the `//#start-akka-management` meant that the generated paradox docs would be missing the import statement.
For future similar PR's in other projects its probably easiest to just change the imports from `import akka` to `import org.apache.pekko` without re-organizing everything. Otherwise you have to manually inspect the imports to make sure that you don't break the docs (this is what I have been and its somewhat painful and takes many hours).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org