You are viewing a plain text version of this content. The canonical link for it is here.
Posted to rivet-dev@tcl.apache.org by Massimo Manghi <mx...@apache.org> on 2012/09/13 16:40:09 UTC

Rivet 2.1 and 2.0 status

On May 9th I wrote to this list a message with a list of TODOs for the 
2.1 release. This checklist was also published on the wiki 
(http://wiki.apache.org/tcl/RivetPlanning). Most of what was on that 
list has been done now.

An important goal I failed to meet was the rewriting of the multipart 
message handling. This was the main goal Valery was working on years ago 
before he silently quit the project. Rewriting the multipart message 
handling on libapreq2 was a sensible proposal but it requires probably 
more than a simple tweaking of the code.

Another issue with the current release is the lack for manual pages for 
the commands provided by rivetCrypt.c and rivetList.c.

Along with the planned work I fixed the following bugs

  - #53543: Use variables with names of tables instead of a fixed value
  - #53703: DIO handles don't return correctly unix timestamp
  - #53544: Remove unused variables

I also fixed undocumented bugs in the Sqlite support for DIO and added 
support for Sqlite working with package Session

Bugs open for which a fix could target 2.1.0 and 2.0.6

  - #52909: form select multiple default broken
  - #52653: load_responses has side effect to set dest(__<var>) on 
multiple occurences of var
  - #53396: Tests don't run on Solaris (id command has different output 
format)
  - #53463: package Rivet should provide actual version number
  - #53732: Functions to get public variables do not return anything...
  - #53733: DIOObject count command fails when -keyfield is not 
specified

If we could work on them I think we could release 2.0.6 and 2.1.0 in 
reasonable time.

  I think bugs

  - #53805: ?> should only be interpreted as ENDTAG after a command 
terminator
  - #53661: Content-Type for POST requests are unreasonably restrictive 
and hardcoded

should probably target subsequent bugfix releases.

Jeff suggests bug #53805 might have a simple solution by disabling 
altogether Content-Type checks in apache_request.c, but I would 
recommend an adequate period of analysis and testing in order to avoid 
unwanted consequences.

Bug #53661 comes with a patch kindly provided by Pietro Cerutti. This 
is much trickier as it might break some rivet existing templates

  -- Massimo




---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org


Re: Rivet 2.1 and 2.0 status

Posted by Massimo Manghi <mx...@apache.org>.
Code in branches/2.0 is still building with Tcl 8.4 except for package 
Calendar, which requires the backport of command 'dict' (being confined 
to this toy package I'm sure this is by no means a nuisance). For 
anything else in 'trunk' your welcome to update the code style to 
leading edge Tcl

  -- Massimo


On 2012-09-13 17:30, Damon Courtney wrote:
> Have we moved on to 8.5+ only support?  If so, I'd like to start
> cleaning up some of the older code that still uses Tcl 8.4-isms.
>
> I don't remember where the discussion on this topic eventually led,
> but I think we can all agree to drop 8.4 support if we haven't
> already.
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org


Re: Rivet 2.1 and 2.0 status

Posted by Jeff Lawson <je...@bovine.net>.
FlightAware is fully on 8.5 so we don't mind removal of the 8.4 support.


On Thu, Sep 13, 2012 at 10:30 AM, Damon Courtney <da...@tclhome.com> wrote:

> Have we moved on to 8.5+ only support?  If so, I'd like to start cleaning
> up some of the older code that still uses Tcl 8.4-isms.
>
> I don't remember where the discussion on this topic eventually led, but I
> think we can all agree to drop 8.4 support if we haven't already.
>
>
> On Sep 13, 2012, at 9:57 AM, Harald Oehlmann wrote:
>
> > Thank you Massimo for the analysis
> >
> > Am 13.09.2012 16:40, schrieb Massimo Manghi:
> >> - #52909: form select multiple default broken
> >> - #52653: load_responses has side effect to set dest(__<var>) on
> >> multiple occurences of var
> >
> > I thought I have fixed #52909.
> >
> > #52653 may just be accepted and documented.
> >
> > I may work on it next week.
> >
> > Enjoy,
> > Harald
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
> > For additional commands, e-mail: rivet-dev-help@tcl.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
> For additional commands, e-mail: rivet-dev-help@tcl.apache.org
>
>

Re: Rivet 2.1 and 2.0 status

Posted by Damon Courtney <da...@tclhome.com>.
Have we moved on to 8.5+ only support?  If so, I'd like to start cleaning up some of the older code that still uses Tcl 8.4-isms.

I don't remember where the discussion on this topic eventually led, but I think we can all agree to drop 8.4 support if we haven't already.


On Sep 13, 2012, at 9:57 AM, Harald Oehlmann wrote:

> Thank you Massimo for the analysis
> 
> Am 13.09.2012 16:40, schrieb Massimo Manghi:
>> - #52909: form select multiple default broken
>> - #52653: load_responses has side effect to set dest(__<var>) on
>> multiple occurences of var
> 
> I thought I have fixed #52909.
> 
> #52653 may just be accepted and documented.
> 
> I may work on it next week.
> 
> Enjoy,
> Harald
> 
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
> For additional commands, e-mail: rivet-dev-help@tcl.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org


Re: Rivet 2.1 and 2.0 status

Posted by Harald Oehlmann <ha...@elmicron.de>.
Thank you Massimo for the analysis

Am 13.09.2012 16:40, schrieb Massimo Manghi:
>  - #52909: form select multiple default broken
>  - #52653: load_responses has side effect to set dest(__<var>) on
> multiple occurences of var

I thought I have fixed #52909.

#52653 may just be accepted and documented.

I may work on it next week.

Enjoy,
Harald




---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org


Re: Rivet 2.1 and 2.0 status

Posted by Massimo Manghi <mx...@apache.org>.
On 09/20/2012 02:34 PM, Harald Oehlmann wrote:
>
> This is accepted as it is and should just be documented.
> I have looked to rivet-full.xml
> I would add a phrase, that a key "__varname" means that varname is an array.
>
> Bug closed.
>
> Thank you all, it is a pleasure !!!
> Harald
>
>
I checked docs/xml/commands.xml and I realized I already wrote a 
paragraph with an example describing the case of an array variable 
shipping a list value

I'm going to remove rivet-full.xml

  -- Massimo


---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org


Re: Rivet 2.1 and 2.0 status

Posted by Harald Oehlmann <ha...@elmicron.de>.
Am 13.09.2012 16:40, schrieb Massimo Manghi:
>  - #52909: form select multiple default broken
fixed

I have added the "" to this line:
if {![info exists DefaultArgs($type)]} { return ""}
This is not necessary, as just a return returns the empty string (what I
know bow).

>  - #52653: load_responses has side effect to set dest(__<var>) on
> multiple occurences of var

This is accepted as it is and should just be documented.
I have looked to rivet-full.xml
I would add a phrase, that a key "__varname" means that varname is an array.

Bug closed.

Thank you all, it is a pleasure !!!
Harald

---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org