[GitHub] [airflow] kaxil edited a comment on pull request #12677: Refactor SQL/BigQuery/Qubole/Druid Check operators

[GitBox <gi...@apache.org>]

kaxil edited a comment on pull request #12677:
URL: https://github.com/apache/airflow/pull/12677#issuecomment-782371508


   It is failing unit tests that are related to this PR though:
   
   https://github.com/apache/airflow/pull/12677/checks?check_run_id=1932643565#step:6:942
   
   ```
     _ TestMovingCoreToContrib.test_is_class_deprecated_097_airflow_operators_sql_SQLCheckOperator _
   
     >           raise AssertionError(_error_message()) from cause
     E           AssertionError: expected call not found.
     E           Expected: __init__()
     E           Actual: __init__(conn_id='druid_broker_default')
     
     /usr/local/lib/python3.8/unittest/mock.py:913: AssertionError
     ________ TestMovingCoreToContrib.test_no_redirect_to_deprecated_classes ________
   
   
   ....
   
   
                 if new in all_classes_by_old:
     >               raise AssertionError(
                         f'Deprecation "{old}" to "{new}" is incorrect. '
                         f'Please use \"{all_classes_by_old[new]}\" instead of "{old}".'
                     )
     E               AssertionError: Deprecation "airflow.operators.druid_check_operator.DruidCheckOperator" to "airflow.providers.apache.druid.operators.druid_check.DruidCheckOperator" is incorrect. Please use "airflow.operators.sql.SQLCheckOperator" instead of "airflow.operators.druid_check_operator.DruidCheckOperator".
     
     tests/core/test_core_to_contrib.py:116: AssertionError
     _ TestMovingCoreToContrib.test_warning_on_import_243_airflow_operators_sql_SQLCheckOperator _
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org