[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on a change in pull request #51: Add throughput field for ServiceMeshMetric

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618438787



##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -56,6 +56,9 @@ message ServiceMeshMetric {
     // The sidecar/proxy internal error code, the value bases on the implementation.
     // The envoy internal error codes are listed here, https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
     string internalErrorCode = 14;
+
+    // The throughput detail of the mesh metrics.
+    Throughput throughput = 15;

Review comment:
       Nearly all the current fields (except for `endpoint`, `responseCode`, `status`) exist in TCP, I can't come out with a better place to put `throughput` atm. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org